Failure/foul-magics
1
0
Fork 0
forked from External/mage
Code Pull requests Releases Packages Activity Actions

Make it possible to play lands using hideaway

Browse source 
Previously lands were not playable due to the
ignoreTimings flag being set to false.
Added checks for the hideaway rulings regarding lands.
This commit is contained in:
Kranken 2016-05-25 20:26:23 +02:00 • committed by Anders Åstrand
parent a34cf7115c
commit f06e6a7bbb
2 changed files with 87 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

74
Mage.Tests/src/test/java/org/mage/test/cards/abilities/keywords/HideawayTest.java
View file

@ -118,6 +118,80 @@ public class HideawayTest extends CardTestPlayerBase {
Permanent permanent = getPermanent("Ulamog, the Ceaseless Hunger", playerA);
Card card = currentGame.getCard(permanent.getId());
Assert.assertFalse("Previous exiled card may be no longer face down", card.isFaceDown(currentGame));
}
@Test
public void testCannotPlayLandIfPlayedLand() {
addCard(Zone.HAND, playerA, "Windbrisk Heights");
addCard(Zone.HAND, playerA, "Plains");
addCard(Zone.LIBRARY, playerA, "Ghost Quarter");
skipInitShuffling();
addCard(Zone.BATTLEFIELD, playerA, "Plains", 1);
addCard(Zone.BATTLEFIELD, playerA, "Auriok Champion", 3);
playLand(1, PhaseStep.PRECOMBAT_MAIN, playerA, "Windbrisk Heights");
setChoice(playerA, "Ghost Quarter");
playLand(3, PhaseStep.PRECOMBAT_MAIN, playerA, "Plains");
attack(3, playerA, "Auriok Champion");
attack(3, playerA, "Auriok Champion");
attack(3, playerA, "Auriok Champion");
activateAbility(3, PhaseStep.DECLARE_BLOCKERS, playerA, "{W},");
setStopAt(3, PhaseStep.END_COMBAT);
execute();
assertPermanentCount(playerA, "Ghost Quarter", 0);
assertTapped("Windbrisk Heights", true);
}
@Test
public void testCannotPlayLandIfNotOwnTurn() {
addCard(Zone.HAND, playerA, "Mosswort Bridge");
addCard(Zone.LIBRARY, playerA, "Ghost Quarter");
skipInitShuffling();
addCard(Zone.BATTLEFIELD, playerA, "Forest", 1);
addCard(Zone.BATTLEFIELD, playerA, "Dross Crocodile", 2);// 5/1
playLand(1, PhaseStep.PRECOMBAT_MAIN, playerA, "Mosswort Bridge");
setChoice(playerA, "Ghost Quarter");
activateAbility(2, PhaseStep.PRECOMBAT_MAIN, playerA, "{G},");
setStopAt(2, PhaseStep.BEGIN_COMBAT);
execute();
assertPermanentCount(playerA, "Ghost Quarter", 0);
assertTapped("Mosswort Bridge", true);
}
@Test
public void testCanPlayLandIfNotPlayedLand() {
addCard(Zone.HAND, playerA, "Windbrisk Heights");
addCard(Zone.LIBRARY, playerA, "Ghost Quarter");
skipInitShuffling();
addCard(Zone.BATTLEFIELD, playerA, "Plains", 1);
addCard(Zone.BATTLEFIELD, playerA, "Auriok Champion", 3);
playLand(1, PhaseStep.PRECOMBAT_MAIN, playerA, "Windbrisk Heights");
setChoice(playerA, "Ghost Quarter");
attack(3, playerA, "Auriok Champion");
attack(3, playerA, "Auriok Champion");
attack(3, playerA, "Auriok Champion");
activateAbility(3, PhaseStep.DECLARE_BLOCKERS, playerA, "{W},");
setStopAt(3, PhaseStep.END_COMBAT);
execute();
assertPermanentCount(playerA, "Ghost Quarter", 1);
assertTapped("Windbrisk Heights", true);
Assert.assertEquals(playerA.getLandsPlayed(), 1);
}
}

14
Mage/src/main/java/mage/abilities/effects/common/HideawayPlayEffect.java
View file

@ -30,6 +30,7 @@ package mage.abilities.effects.common;
import mage.abilities.Ability;
import mage.abilities.effects.OneShotEffect;
import mage.cards.Card;
import mage.constants.CardType;
import mage.constants.Outcome;
import mage.game.ExileZone;
import mage.game.Game;
@ -68,7 +69,18 @@ public class HideawayPlayEffect extends OneShotEffect {
if (controller.chooseUse(Outcome.PlayForFree, "Do you want to play " + card.getIdName() + " for free now?", source, game)) {
card.setFaceDown(false, game);
int zcc = card.getZoneChangeCounter(game);
if (!controller.playCard(card, game, true, false)) {
/* 702.74. Hideaway, rulings:
* If the removed card is a land, you may play it as a result of the last ability only if it's your turn
* and you haven't already played a land that turn. This counts as your land play for the turn.
*/
if (card.getCardType().contains(CardType.LAND)) {
if (controller.getLandsPlayed() > 0 || !game.getActivePlayerId().equals(controller.getId())) {
return false;
}
}
if (!controller.playCard(card, game, true, true)) {
if (card.getZoneChangeCounter(game) == zcc) {
card.setFaceDown(true, game);
}