Failure/foul-magics
1
0
Fork 0
forked from External/mage
Code Pull requests Releases Packages Activity Actions

Replace Overriden getTriggerPhrase() with setTriggerPhrase() usage (#9343)

Browse source
This commit is contained in:
Alex Vasile 2022-08-08 23:28:46 -04:00 • committed by GitHub
parent 188e6dd8c1
commit ebdb6b53a4
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
406 changed files with 918 additions and 2665 deletions
Download patch file Download diff file Expand all files Collapse all files

34
Mage/src/main/java/mage/abilities/keyword/HeroicAbility.java
View file

@ -21,7 +21,6 @@ import java.util.UUID;
*/
public class HeroicAbility extends TriggeredAbilityImpl {
public HeroicAbility(Effect effect) {
this(effect, false);
}
@ -35,6 +34,7 @@ public class HeroicAbility extends TriggeredAbilityImpl {
if (isHeroic) {
this.setAbilityWord(AbilityWord.HEROIC);
}
setTriggerPhrase("Whenever you cast a spell that targets {this}, ");
}
public HeroicAbility(final HeroicAbility ability) {
@ -63,29 +63,25 @@ public class HeroicAbility extends TriggeredAbilityImpl {
}
private boolean checkSpell(Spell spell, Game game) {
if (spell != null) {
SpellAbility sa = spell.getSpellAbility();
for (UUID modeId : sa.getModes().getSelectedModes()) {
Mode mode = sa.getModes().get(modeId);
for (Target target : mode.getTargets()) {
if (!target.isNotTarget() && target.getTargets().contains(this.getSourceId())) {
return true;
}
if (spell == null) {
return false;
}
SpellAbility sa = spell.getSpellAbility();
for (UUID modeId : sa.getModes().getSelectedModes()) {
Mode mode = sa.getModes().get(modeId);
for (Target target : mode.getTargets()) {
if (!target.isNotTarget() && target.getTargets().contains(this.getSourceId())) {
return true;
}
for (Effect effect : mode.getEffects()) {
for (UUID targetId : effect.getTargetPointer().getTargets(game, sa)) {
if (targetId.equals(this.getSourceId())) {
return true;
}
}
for (Effect effect : mode.getEffects()) {
for (UUID targetId : effect.getTargetPointer().getTargets(game, sa)) {
if (targetId.equals(this.getSourceId())) {
return true;
}
}
}
}
return false;
}
@Override
public String getTriggerPhrase() {
return "Whenever you cast a spell that targets {this}, ";
}
}