Failure/foul-magics
1
0
Fork 0
forked from External/mage
Code Pull requests Releases Packages Activity Actions

Replace Overriden getTriggerPhrase() with setTriggerPhrase() usage (#9343)

Browse source
This commit is contained in:
Alex Vasile 2022-08-08 23:28:46 -04:00 • committed by GitHub
parent 188e6dd8c1
commit ebdb6b53a4
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
406 changed files with 918 additions and 2665 deletions
Download patch file Download diff file Expand all files Collapse all files

19
Mage/src/main/java/mage/abilities/common/SpellCastControllerTriggeredAbility.java
View file

@ -15,13 +15,13 @@ import mage.target.targetpointer.FixedTarget;
*/
public class SpellCastControllerTriggeredAbility extends TriggeredAbilityImpl {
protected FilterSpell filter;
protected String rule;
protected final FilterSpell filter;
protected String rule; // TODO: This sould be final, but is not because of the telescoping contructors
// The source SPELL that triggered the ability will be set as target to effect
protected boolean rememberSource = false;
protected boolean rememberSource;
// Use it if you want remember CARD instead spell
protected boolean rememberSourceAsCard = false;
protected boolean rememberSourceAsCard;
public SpellCastControllerTriggeredAbility(Effect effect, boolean optional) {
this(Zone.BATTLEFIELD, effect, StaticFilters.FILTER_SPELL_A, optional, false);
@ -49,6 +49,7 @@ public class SpellCastControllerTriggeredAbility extends TriggeredAbilityImpl {
this.filter = filter;
this.rememberSource = rememberSource;
this.rememberSourceAsCard = rememberSourceAsCard;
setTriggerPhrase("Whenever you cast " + filter.getMessage() + ", ");
}
public SpellCastControllerTriggeredAbility(final SpellCastControllerTriggeredAbility ability) {
@ -86,15 +87,7 @@ public class SpellCastControllerTriggeredAbility extends TriggeredAbilityImpl {
@Override
public String getRule() {
if (rule != null && !rule.isEmpty()) {
return rule;
}
return super.getRule();
}
@Override
public String getTriggerPhrase() {
return "Whenever you cast " + filter.getMessage() + ", ";
return rule != null ? rule : super.getRule();
}
@Override