Failure/foul-magics
1
0
Fork 0
forked from External/mage
Code Pull requests Releases Packages Activity Actions

Feature: Retro Border Renderer (#13563)

Browse source 
* Add Retro Card Renderer

* Updated old sets with retro frames

Adds sets:
* 30th Anniversary Play Promos
* 30th Anniversary Misc Promos
* Eternal Weekend
* MagicFest 2025
* Modern Horizon 2 Timeshifts
This commit is contained in:
Jmlundeen 2025-04-22 17:37:57 -05:00 • committed by GitHub
parent 36196742ad
commit e34ebe740e
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
151 changed files with 16549 additions and 14836 deletions
Download patch file Download diff file Expand all files Collapse all files

46
Mage.Verify/src/test/java/mage/verify/VerifyCardDataTest.java
View file

@ -668,27 +668,33 @@ public class VerifyCardDataTest {
}
// index for missing cards
String code = MtgJsonService.xMageToMtgJsonCodes.getOrDefault(set.getCode(), set.getCode()) + " - " + jsonCard.getNameAsFull() + " - " + jsonCard.number;
foundedJsonCards.add(code);
// String code = MtgJsonService.xMageToMtgJsonCodes.getOrDefault(set.getCode(), set.getCode()) + " - " + jsonCard.getNameAsFull() + " - " + jsonCard.number;
// foundedJsonCards.add(code);
//
// // CHECK: only lands can use full art in current version;
// // Another cards must be in text render mode as normal, example: https://scryfall.com/card/sld/76/athreos-god-of-passage
// // TODO: add support textless cards like https://scryfall.com/card/sch/12/thalia-and-the-gitrog-monster
// boolean isLand = card.getRarity().equals(Rarity.LAND);
// if (card.isFullArt() && !isLand) {
// errorsList.add("Error: only lands can use full art setting: "
// + set.getCode() + " - " + set.getName() + " - " + card.getName() + " - " + card.getCardNumber());
// }
//
// // CHECK: must use full art setting
// if (jsonCard.isFullArt && isLand && !card.isFullArt()) {
// errorsList.add("Error: card must use full art setting: "
// + set.getCode() + " - " + set.getName() + " - " + card.getName() + " - " + card.getCardNumber());
// }
//
// // CHECK: must not use full art setting
// if (!jsonCard.isFullArt && card.isFullArt()) {
// errorsList.add("Error: card must NOT use full art setting: "
// + set.getCode() + " - " + set.getName() + " - " + card.getName() + " - " + card.getCardNumber());
// }
// CHECK: only lands can use full art in current version;
// Another cards must be in text render mode as normal, example: https://scryfall.com/card/sld/76/athreos-god-of-passage
// TODO: add support textless cards like https://scryfall.com/card/sch/12/thalia-and-the-gitrog-monster
boolean isLand = card.getRarity().equals(Rarity.LAND);
if (card.isFullArt() && !isLand) {
errorsList.add("Error: only lands can use full art setting: "
+ set.getCode() + " - " + set.getName() + " - " + card.getName() + " - " + card.getCardNumber());
}
// CHECK: must use full art setting
if (jsonCard.isFullArt && isLand && !card.isFullArt()) {
errorsList.add("Error: card must use full art setting: "
+ set.getCode() + " - " + set.getName() + " - " + card.getName() + " - " + card.getCardNumber());
}
// CHECK: must not use full art setting
if (!jsonCard.isFullArt && card.isFullArt()) {
errorsList.add("Error: card must NOT use full art setting: "
// CHECK: must use retro frame setting
if ((jsonCard.frameVersion.equals("1993") || jsonCard.frameVersion.equals("1997")) && !card.isRetroFrame()) {
errorsList.add("Error: card must use retro art setting: "
+ set.getCode() + " - " + set.getName() + " - " + card.getName() + " - " + card.getCardNumber());
}
}