Failure/foul-magics
1
0
Fork 0
forked from External/mage
Code Pull requests Releases Packages Activity Actions

Lazotep Convert fix (#10578)

Browse source 
* Fix Lazotep Convert card (add color, need to actually apply the applier)

* Don't copy Transformed status, add test
This commit is contained in:
ssk97 2023-07-06 22:26:27 -07:00 • committed by GitHub
parent 063429b70a
commit e1edec542c
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 59 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

7
Mage.Sets/src/mage/cards/l/LazotepConvert.java
View file

@ -63,7 +63,7 @@ class LazotepConvertCopyEffect extends OneShotEffect {
blueprint.getPower().setModifiedBaseValue(4);
blueprint.getToughness().setModifiedBaseValue(4);
blueprint.addSubType(SubType.ZOMBIE);
blueprint.getColor().setColor(ObjectColor.BLACK);
blueprint.getColor().addColor(ObjectColor.BLACK);
return true;
}
};
@ -93,8 +93,11 @@ class LazotepConvertCopyEffect extends OneShotEffect {
if (copyFromCard == null) {
return true;
}
Card modifiedCopy = copyFromCard.copy();
//Appliers must be applied before CopyEffect, its applier setting is just for copies of copies
applier.apply(game, modifiedCopy, source, source.getSourceId());
game.addEffect(new CopyEffect(
Duration.Custom, copyFromCard, source.getSourceId()
Duration.Custom, modifiedCopy, source.getSourceId()
).setApplier(applier), source);
return true;
}

46
Mage.Tests/src/test/java/org/mage/test/cards/copy/LazotepConvertTest.java Normal file
View file

@ -0,0 +1,46 @@
package org.mage.test.cards.copy;
import mage.constants.PhaseStep;
import mage.constants.SubType;
import mage.constants.Zone;
import org.junit.Test;
import org.mage.test.serverside.base.CardTestPlayerBase;
import java.util.stream.Collectors;
/**
* @author notgreat
*/
public class LazotepConvertTest extends CardTestPlayerBase {
@Test
public void testInvastionAmonkhetTransformed() {
addCard(Zone.BATTLEFIELD, playerA, "Badlands", 3);
addCard(Zone.BATTLEFIELD, playerA, "Underground Sea", 3);
addCard(Zone.GRAVEYARD, playerA, "Mutagen Connoisseur", 1);
addCard(Zone.HAND, playerA, "Invasion of Amonkhet");
addCard(Zone.HAND, playerA,"Char" );
castSpell(1, PhaseStep.PRECOMBAT_MAIN, playerA, "Invasion of Amonkhet");
waitStackResolved(1,PhaseStep.PRECOMBAT_MAIN);
castSpell(1, PhaseStep.PRECOMBAT_MAIN, playerA, "Char", "Invasion of Amonkhet");
//setChoice(playerA,true);
//addTarget(playerA,"Mutagen Connoisseur");
//These are auto-chosen by the AI
//Should make a 4/4 BGU Vedalken Mutant Zombie
//And count as transformed, so it's a 5/4
setStopAt(1, PhaseStep.BEGIN_COMBAT);
execute();
currentGame.debugMessage("Graveyard: "+currentGame.getPlayer(playerA.getId()).getGraveyard().stream()
.map(x -> currentGame.getObject(x).getClass().getSimpleName()).collect(Collectors.toList()));
assertPermanentCount(playerA, "Mutagen Connoisseur", 1);
assertGraveyardCount(playerA, "Mutagen Connoisseur", 1);
assertSubtype("Mutagen Connoisseur", SubType.ZOMBIE);
assertSubtype("Mutagen Connoisseur", SubType.VEDALKEN);
assertColor(playerA,"Mutagen Connoisseur","BGU",true);
assertPowerToughness(playerA,"Mutagen Connoisseur",5,4);
}
}

10
Mage/src/main/java/mage/abilities/effects/common/CopyEffect.java
View file

@ -136,8 +136,14 @@ public class CopyEffect extends ContinuousEffectImpl {
permanent.setStartingDefense(copyFromObject.getStartingDefense());
if (copyFromObject instanceof Permanent) {
Permanent targetPermanent = (Permanent) copyFromObject;
permanent.setTransformed(targetPermanent.isTransformed());
permanent.setSecondCardFace(targetPermanent.getSecondCardFace());
//707.2. When copying an object, the copy acquires the copiable values of the original object’s characteristics [..]
//110.5. A permanent's status is its physical state. There are four status categories, each of which has two possible values:
// tapped/untapped, flipped/unflipped, face up/face down, and phased in/phased out.
// Each permanent always has one of these values for each of these categories.
//110.5a Status is not a characteristic, though it may affect a permanent’s characteristics.
//Being transformed is not a copiable characteristic, nor is the back side of a DFC
//permanent.setTransformed(targetPermanent.isTransformed());
//permanent.setSecondCardFace(targetPermanent.getSecondCardFace());
permanent.setFlipCard(targetPermanent.isFlipCard());
permanent.setFlipCardName(targetPermanent.getFlipCardName());
}