Failure/foul-magics
1
0
Fork 0
forked from External/mage
Code Pull requests Releases Packages Activity Actions

Refactoring subtypes to make Maskwood Nexus work (ready for review) (#7432)

Browse source 
* removed and renamed SubTypeList

* updated subtype test

* refactored Changeling to be an ability that actually does something

* moved isAllCreatureTypes into SubTypes class

* renamed copyTo method to copyFrom

* added removeAllCreatureTypes where usable

* replaced some subtype methods

* replaced some more subtype methods

* replaced subtype mass add/remove methods

* updated more subtype methods

* fixed some errors

* made common shared creature type predicate

* refactored another card involving subtypes

* Added usage of object attribute in subTypes's write operations;

* Refactor: use same param styles in subtype methods

* Refactor: simplified usage of copy appliers;

* Refactor: fixed code usage in CopyApplier

Co-authored-by: Oleg Agafonov <jaydi85@gmail.com>
This commit is contained in:
Evan Kranzler 2021-01-26 08:52:35 -05:00 • committed by GitHub
parent 6f42b90305
commit dacf30f4b9
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
259 changed files with 1857 additions and 1922 deletions
Download patch file Download diff file Expand all files Collapse all files

21
Mage/src/main/java/mage/game/command/Commander.java
View file

@ -18,7 +18,7 @@ import mage.constants.SuperType;
import mage.game.Game;
import mage.game.events.ZoneChangeEvent;
import mage.util.GameLog;
import mage.util.SubTypeList;
import mage.util.SubTypes;
import java.util.ArrayList;
import java.util.List;
@ -130,7 +130,6 @@ public class Commander implements CommandObject {
@Override
public void setName(String name) {
}
@Override
@ -139,7 +138,12 @@ public class Commander implements CommandObject {
}
@Override
public SubTypeList getSubtype(Game game) {
public SubTypes getSubtype() {
return sourceObject.getSubtype();
}
@Override
public SubTypes getSubtype(Game game) {
return sourceObject.getSubtype(game);
}
@ -167,6 +171,11 @@ public class Commander implements CommandObject {
return otherAbilities != null && otherAbilities.contains(ability);
}
@Override
public ObjectColor getColor() {
return sourceObject.getColor();
}
@Override
public ObjectColor getColor(Game game) {
return sourceObject.getColor(game);
@ -245,7 +254,7 @@ public class Commander implements CommandObject {
}
@Override
public boolean isAllCreatureTypes() {
public boolean isAllCreatureTypes(Game game) {
return false;
}
@ -253,6 +262,10 @@ public class Commander implements CommandObject {
public void setIsAllCreatureTypes(boolean value) {
}
@Override
public void setIsAllCreatureTypes(Game game, boolean value) {
}
@Override
public List<TextPart> getTextParts() {
throw new UnsupportedOperationException("Not supported yet."); //To change body of generated methods, choose Tools | Templates.