Failure/foul-magics
1
0
Fork 0
forked from External/mage
Code Pull requests Releases Packages Activity Actions

Equals should be compared with == but not equals()

Browse source
This commit is contained in:
vraskulin 2017-03-22 14:50:46 +03:00
parent 1f9b51d833
commit d93061c0bc
175 changed files with 348 additions and 344 deletions
Download patch file Download diff file Expand all files Collapse all files

10
Mage/src/main/java/mage/Mana.java
View file

@ -846,19 +846,19 @@ public class Mana implements Comparable<Mana>, Serializable, Copyable<Mana> {
* in {@link ColoredManaSymbol}.
*/
public int getColor(final ColoredManaSymbol color) {
if (color.equals(ColoredManaSymbol.G)) {
if (color == ColoredManaSymbol.G) {
return green;
}
if (color.equals(ColoredManaSymbol.R)) {
if (color == ColoredManaSymbol.R) {
return red;
}
if (color.equals(ColoredManaSymbol.B)) {
if (color == ColoredManaSymbol.B) {
return black;
}
if (color.equals(ColoredManaSymbol.U)) {
if (color == ColoredManaSymbol.U) {
return blue;
}
if (color.equals(ColoredManaSymbol.W)) {
if (color == ColoredManaSymbol.W) {
return white;
}
return 0;