Failure/foul-magics
1
0
Fork 0
forked from External/mage
Code Pull requests Releases Packages Activity Actions

Remove superfluous addManaCost method (#11288)

Browse source 
* no need to specify mana cost, just add cost

* handle all mana costs through addcost method only

* eliminate another constructor

* more constructor cleanup
This commit is contained in:
xenohedron 2023-10-09 15:25:19 -04:00 • committed by GitHub
parent 4e2a5bd5a9
commit d7afa37893
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
53 changed files with 153 additions and 338 deletions
Download patch file Download diff file Expand all files Collapse all files

5
Mage/src/main/java/mage/players/PlayerImpl.java
View file

@ -1113,9 +1113,6 @@ public abstract class PlayerImpl implements Player, Serializable {
.computeIfAbsent(sourceId, k -> new HashMap<>())
.put(identifier, costs != null ? costs.copy() : null);
if (identifier == null) {
boolean a = true;
}
}
@Override
@ -1236,7 +1233,7 @@ public abstract class PlayerImpl implements Player, Serializable {
} else {
spellAbility.clearManaCosts();
spellAbility.clearManaCostsToPay();
spellAbility.addManaCost(alternateCosts.copy());
spellAbility.addCost(alternateCosts.copy());
}
spellAbility.clearCosts();
spellAbility.addCost(costs);