Failure/foul-magics
1
0
Fork 0
forked from External/mage
Code Pull requests Releases Packages Activity Actions

Tests: improved addCard command, now it can add card from specific set (use 40K:Plains as card name param, #10139)

Browse source
This commit is contained in:
Oleg Agafonov 2023-03-23 23:05:33 +04:00
parent 92706d23cb
commit d019acbd55
8 changed files with 125 additions and 24 deletions
Download patch file Download diff file Expand all files Collapse all files

12
Mage.Verify/src/test/java/mage/verify/VerifyCardDataTest.java
View file

@ -964,6 +964,12 @@ public class VerifyCardDataTest {
cardNames.add(cardInfo.getName());
}
// CHECK: set code must be compatible with tests commands format
// how-to fix: increase lookup lenth
if (set.getCode().length() + 1 > CardUtil.TESTS_SET_CODE_LOOKUP_LENGTH) {
errorsList.add("Error: set code too big for test commads lookup: " + set.getCode() + ", lookup length: " + CardUtil.TESTS_SET_CODE_LOOKUP_LENGTH);
}
boolean containsDoubleSideCards = false;
Map<String, String> cardNumbers = new HashMap<>();
for (ExpansionSet.SetCardInfo cardInfo : set.getSetCardInfo()) {
@ -989,6 +995,12 @@ public class VerifyCardDataTest {
errorsList.add("Error: card name or number contains non-ascii symbols: " + set.getCode() + " - " + set.getName() + " - " + card.getName() + " - " + card.getCardNumber());
}
// CHECK: card name must not contain : symbol due set:name commands format in test engine
// (if it exists then decrease TESTS_SET_CODE_LOOKUP_LENGTH)
if (CardUtil.substring(card.getName(), CardUtil.TESTS_SET_CODE_LOOKUP_LENGTH).contains(":")) {
errorsList.add("Error: card name can't contain : symbol: " + set.getCode() + " - " + set.getName() + " - " + card.getName() + " - " + card.getCardNumber());
}
// CHECK: card number must start with 09-aZ symbols (wrong symbol example: *123)
// if you found card with number like *123 then report it to scryfall to fix to 123*
if (!Character.isLetterOrDigit(card.getCardNumber().charAt(0))) {