Failure/foul-magics
1
0
Fork 0
forked from External/mage
Code Pull requests Releases Packages Activity Actions

Reworking triggered ability text generation to allow for ability words and flavor words to be added more easily (#8010)

Browse source 
* refactor all instances of getRule in triggered abilities using new getTriggerPrefix method

* updated triggered ability rules generation

* renamed method

* fixed a test failure

* some more refactoring

* simplified some instances of ability word usage
This commit is contained in:
Evan Kranzler 2021-07-15 07:46:38 -04:00 • committed by GitHub
parent 0a31110164
commit ca80806400
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
398 changed files with 946 additions and 989 deletions
Download patch file Download diff file Expand all files Collapse all files

15
Mage/src/main/java/mage/abilities/keyword/ChannelAbility.java
View file

@ -2,13 +2,13 @@
package mage.abilities.keyword;
import mage.constants.Zone;
import mage.abilities.ActivatedAbilityImpl;
import mage.abilities.costs.common.DiscardSourceCost;
import mage.abilities.costs.mana.ManaCostsImpl;
import mage.abilities.effects.Effect;
import mage.constants.AbilityWord;
import mage.constants.TimingRule;
import mage.constants.Zone;
public class ChannelAbility extends ActivatedAbilityImpl {
@ -16,11 +16,12 @@ public class ChannelAbility extends ActivatedAbilityImpl {
public ChannelAbility(String manaString, Effect effect) {
this(manaString, effect, TimingRule.INSTANT);
}
public ChannelAbility(String manaString, Effect effect, TimingRule timing) {
super(Zone.HAND, effect, new ManaCostsImpl(manaString));
this.addCost(new DiscardSourceCost());
this.timing = timing;
this.setAbilityWord(AbilityWord.CHANNEL);
}
public ChannelAbility(final ChannelAbility ability) {
@ -34,12 +35,10 @@ public class ChannelAbility extends ActivatedAbilityImpl {
@Override
public String getRule() {
StringBuilder sb = new StringBuilder("<i>Channel</i> &mdash; ");
sb.append(super.getRule());
if(this.timing == TimingRule.SORCERY) {
sb.append(" Activate only as a sorcery.");
if (this.timing == TimingRule.SORCERY) {
return super.getRule() + " Activate only as a sorcery.";
}
return sb.toString();
return super.getRule();
}
}