Failure/foul-magics
1
0
Fork 0
forked from External/mage
Code Pull requests Releases Packages Activity Actions

Reworking triggered ability text generation to allow for ability words and flavor words to be added more easily (#8010)

Browse source 
* refactor all instances of getRule in triggered abilities using new getTriggerPrefix method

* updated triggered ability rules generation

* renamed method

* fixed a test failure

* some more refactoring

* simplified some instances of ability word usage
This commit is contained in:
Evan Kranzler 2021-07-15 07:46:38 -04:00 • committed by GitHub
parent 0a31110164
commit ca80806400
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
398 changed files with 946 additions and 989 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Mage/src/main/java/mage/abilities/common/SacrificeAllTriggeredAbility.java
View file

@ -62,7 +62,7 @@ public class SacrificeAllTriggeredAbility extends TriggeredAbilityImpl {
}
@Override
public String getRule() {
public String getTriggerPhrase() {
String targetControllerText = "a player sacrifices ";
switch (sacrificingPlayer) {
case YOU:
@ -72,6 +72,6 @@ public class SacrificeAllTriggeredAbility extends TriggeredAbilityImpl {
targetControllerText = "an opponent sacrifices ";
break;
}
return "Whenever " + targetControllerText + filter.getMessage() + ", " + super.getRule();
return "Whenever " + targetControllerText + filter.getMessage() + ", ";
}
}