Failure/foul-magics
1
0
Fork 0
forked from External/mage
Code Pull requests Releases Packages Activity Actions

Reworking triggered ability text generation to allow for ability words and flavor words to be added more easily (#8010)

Browse source 
* refactor all instances of getRule in triggered abilities using new getTriggerPrefix method

* updated triggered ability rules generation

* renamed method

* fixed a test failure

* some more refactoring

* simplified some instances of ability word usage
This commit is contained in:
Evan Kranzler 2021-07-15 07:46:38 -04:00 • committed by GitHub
parent 0a31110164
commit ca80806400
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
398 changed files with 946 additions and 989 deletions
Download patch file Download diff file Expand all files Collapse all files

3
Mage/src/main/java/mage/abilities/common/DealsDamageToACreatureTriggeredAbility.java
View file

@ -71,7 +71,7 @@ public class DealsDamageToACreatureTriggeredAbility extends TriggeredAbilityImpl
}
@Override
public String getRule() {
public String getTriggerPhrase() {
StringBuilder sb = new StringBuilder("Whenever {this} deals ");
if (combatOnly) {
sb.append("combat ");
@ -83,7 +83,6 @@ public class DealsDamageToACreatureTriggeredAbility extends TriggeredAbilityImpl
sb.append(filter.getMessage());
sb.append(", ");
}
sb.append(super.getRule());
return sb.toString();
}