docs: added additional comments for #11933

This commit is contained in:
Oleg Agafonov 2024-03-12 11:13:43 +04:00
parent f207945830
commit b746a601f2
2 changed files with 5 additions and 1 deletions

View file

@ -139,6 +139,10 @@ public interface Target extends Serializable {
boolean isRandom();
/**
* WARNING, if you need random choice then call it by target's choose method, not player's choose
* see https://github.com/magefree/mage/issues/11933
*/
void setRandom(boolean atRandom);
UUID getFirstTarget();

View file

@ -34,7 +34,7 @@ public abstract class TargetImpl implements Target {
protected boolean chosen = false;
// is the target handled as targeted spell/ability (notTarget = true is used for not targeted effects like e.g. sacrifice)
protected boolean notTarget = false;
protected boolean atRandom = false;
protected boolean atRandom = false; // for inner choose logic
protected UUID targetController = null; // if null the ability controller is the targetController
protected UUID abilityController = null; // only used if target controller != ability controller