Failure/foul-magics
1
0
Fork 0
forked from External/mage
Code Pull requests Releases Packages Activity Actions

add verify checks for Double Faced Cards having abilities on main card

Browse source 
* add booleans to card scanner, restricting to checking cards by name and set. Reduces duplication of verify checks across sets.
This commit is contained in:
jmlundeen 2025-11-27 09:39:46 -06:00
parent 69e20b1061
commit b32a786236
3 changed files with 32 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

19
Mage.Verify/src/test/java/mage/verify/VerifyCardDataTest.java
View file

@ -329,7 +329,8 @@ public class VerifyCardDataTest {
checkWrongAbilitiesTextStart();
int cardIndex = 0;
for (Card card : CardScanner.getAllCards()) {
List<Card> allCards = CardScanner.getAllCards(true, true, false);
for (Card card : allCards) {
cardIndex++;
if (card instanceof CardWithHalves) {
check(((CardWithHalves) card).getLeftHalfCard(), cardIndex);
@ -346,7 +347,7 @@ public class VerifyCardDataTest {
printMessages(outputMessages);
if (failed > 0) {
Assert.fail(String.format("found %d errors in %d cards verify (see errors list above)", failed, CardScanner.getAllCards().size()));
Assert.fail(String.format("found %d errors in %d cards verify (see errors list above)", failed, allCards.size()));
}
}
@ -2291,6 +2292,20 @@ public class VerifyCardDataTest {
fail(card, "abilities", "card has backup but is missing this.addAbility(backupAbility)");
}
// special check: DFC main card should not have abilities
if (card instanceof DoubleFacedCardHalf && !card.getMainCard().getInitAbilities().isEmpty()) {
fail(card, "abilities", "transforming double-faced card should not have abilities on the main card");
}
// TODO: remove after transform ability removed
// special check: new DFC implementation should not have transform ability
if (card instanceof DoubleFacedCardHalf && card.getAbilities().containsClass(TransformAbility.class)
&& !card.getAbilities().containsClass(DayboundAbility.class)
&& !card.getAbilities().containsClass(CraftAbility.class)
&& !card.getAbilities().containsClass(SiegeAbility.class)) {
fail(card, "abilities", "new transforming double-faced card should not have transform ability");
}
// special check: Werewolves front ability should only be on front and vice versa
if (card.getAbilities().containsClass(WerewolfFrontTriggeredAbility.class) && (card.isNightCard() || (card instanceof DoubleFacedCardHalf && ((DoubleFacedCardHalf) card).isBackSide()))) {
fail(card, "abilities", "card is a back face werewolf with a front face ability");