Fix bugs with dies triggers due to short living LKI reset (#12438)

* replace applyEffects() with processAction() for card usages

* update Goblin Welder and test

* add test for Historian's Wisdom

* enable other related tests

* only reset short living LKI for process action, not all apply effects

* update docs

* remove applyEffects from condition in Historian's Wisdom

* add another test case
This commit is contained in:
xenohedron 2024-06-09 18:56:19 -04:00 committed by GitHub
parent be8a52fe60
commit aeaeccb63b
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
22 changed files with 103 additions and 49 deletions

View file

@ -691,7 +691,7 @@ public abstract class PermanentImpl extends CardImpl implements Permanent {
+ CardUtil.getSourceLogName(game, source, this.getId()));
this.setTransformed(!this.transformed);
this.transformCount++;
game.applyEffects();
game.applyEffects(); // not process action - no firing of simultaneous events yet
this.replaceEvent(EventType.TRANSFORMING, game);
game.addSimultaneousEvent(GameEvent.getEvent(EventType.TRANSFORMED, this.getId(), this.getControllerId()));
return true;