Clean up triggered ability text generation (#10627)

* move "or battle" to its own class

* move "or planeswalker" to its own class

* remove strange way of setting custom text

* finally remove getTriggerPhrase

* copy constructor visibility

* fix Vraska

Mage/src/main/java/mage/abilities/common/DealsCombatDamageToAPlayerOrBattleTriggeredAbility.java

@@ -0,0 +1,53 @@
+package mage.abilities.common;
+
+import mage.abilities.TriggeredAbilityImpl;
+import mage.abilities.effects.Effect;
+import mage.constants.Zone;
+import mage.game.Game;
+import mage.game.events.DamagedEvent;
+import mage.game.events.GameEvent;
+import mage.game.permanent.Permanent;
+
+/**
+ * @author xenohedron
+ */
+public class DealsCombatDamageToAPlayerOrBattleTriggeredAbility extends TriggeredAbilityImpl {
+
+    public DealsCombatDamageToAPlayerOrBattleTriggeredAbility(Effect effect, boolean optional) {
+        super(Zone.BATTLEFIELD, effect, optional);
+        setTriggerPhrase("Whenever {this} deals combat damage to a player or battle, ");
+    }
+
+
+    protected DealsCombatDamageToAPlayerOrBattleTriggeredAbility(final DealsCombatDamageToAPlayerOrBattleTriggeredAbility ability) {
+        super(ability);
+    }
+
+    @Override
+    public DealsCombatDamageToAPlayerOrBattleTriggeredAbility copy() {
+        return new DealsCombatDamageToAPlayerOrBattleTriggeredAbility(this);
+    }
+
+    @Override
+    public boolean checkEventType(GameEvent event, Game game) {
+        return event.getType() == GameEvent.EventType.DAMAGED_PLAYER
+                || event.getType() == GameEvent.EventType.DAMAGED_PERMANENT;
+    }
+
+    @Override
+    public boolean checkTrigger(GameEvent event, Game game) {
+        if (!event.getSourceId().equals(getSourceId())
+                || !((DamagedEvent) event).isCombatDamage()) {
+            return false;
+        }
+        if (event.getType() == GameEvent.EventType.DAMAGED_PERMANENT) {
+            Permanent permanent = game.getPermanent(event.getTargetId());
+            if (permanent == null || !permanent.isBattle(game)) {
+                return false;
+            }
+        }
+        getAllEffects().setValue("damage", event.getAmount());
+        return true;
+    }
+
+}