Failure/foul-magics
1
0
Fork 0
forked from External/mage
Code Pull requests Releases Packages Activity Actions

Fixing copy and cast from exile effects (#10436)

Browse source 
* Added unit test for magefree/mage#10435

* Added test for potential breakage of prosper functionality

* Copies of cards are now created in the right zone

* Added PlayCardTriggeredAbility

This triggered ability checks to make sure a card was actually played (as opposed to a copy of a card).
Common abilities have been refactored to use this new ability

* Added mizzix's mastery overload test

* Fixed Mizzix's mastery overload

* Added new ability to Juju Bubble

---------

Co-authored-by: xenohedron <xenohedron@users.noreply.github.com>
This commit is contained in:
Alexander Novotny 2023-06-08 18:32:59 -07:00 • committed by GitHub
parent 2f79343bc8
commit a0f8a42699
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
23 changed files with 337 additions and 225 deletions
Download patch file Download diff file Expand all files Collapse all files

105
Mage/src/main/java/mage/abilities/common/PlayCardTriggeredAbility.java Normal file
View file

@ -0,0 +1,105 @@
package mage.abilities.common;
import mage.abilities.TriggeredAbility;
import mage.abilities.TriggeredAbilityImpl;
import mage.abilities.effects.Effect;
import mage.constants.TargetController;
import mage.constants.Zone;
import mage.game.Game;
import mage.game.events.GameEvent;
// Author: alexander-novo
// A triggered ability for cards which say "whenever <someone> play(s) a card..."
public class PlayCardTriggeredAbility extends TriggeredAbilityImpl {
private final TargetController targetController;
/**
*
* @param targetController Which player(s) playing cards can trigger this ability. Only [ANY, NOT_YOU, OPPONENT, YOU] are supported.
* @param zone
* @param effect
*/
public PlayCardTriggeredAbility(TargetController targetController, Zone zone, Effect effect) {
super(zone, effect);
this.targetController = targetController;
constructTriggerPhrase();
}
/**
*
* @param targetController Which player(s) playing cards can trigger this ability. Only [ANY, NOT_YOU, OPPONENT, YOU] are supported.
* @param zone
* @param effect
* @param optional
*/
public PlayCardTriggeredAbility(TargetController targetController, Zone zone, Effect effect, boolean optional) {
super(zone, effect, optional);
this.targetController = targetController;
constructTriggerPhrase();
}
private void constructTriggerPhrase() {
switch (targetController) {
case ANY:
setTriggerPhrase("Whenever a player plays play a card, ");
break;
case NOT_YOU:
setTriggerPhrase("Whenever another player plays a card, ");
break;
case OPPONENT:
setTriggerPhrase("Whenever an opponent plays a card, ");
break;
case YOU:
setTriggerPhrase("Whenever you play a card, ");
break;
default:
throw new UnsupportedOperationException("TargetController not supported");
}
}
public PlayCardTriggeredAbility(final PlayCardTriggeredAbility ability) {
super(ability);
this.targetController = ability.targetController;
}
@Override
public boolean checkEventType(GameEvent event, Game game) {
return event.getType() == GameEvent.EventType.SPELL_CAST
|| event.getType() == GameEvent.EventType.LAND_PLAYED;
}
@Override
public boolean checkTrigger(GameEvent event, Game game) {
boolean playerMatches;
switch (targetController) {
case ANY:
playerMatches = true;
break;
case NOT_YOU:
playerMatches = !isControlledBy(event.getPlayerId());
break;
case OPPONENT:
playerMatches = game.getPlayer(getControllerId()).hasOpponent(event.getPlayerId(), game);
break;
case YOU:
playerMatches = isControlledBy(event.getPlayerId());
break;
default:
throw new UnsupportedOperationException("TargetController not supported");
}
// Make sure that, if a spell was cast, it came from an actual card (and not a copy of a card)
return playerMatches && (event.getType() != GameEvent.EventType.SPELL_CAST
|| !game.getSpell(event.getTargetId()).getCard().isCopy());
}
@Override
public TriggeredAbility copy() {
return new PlayCardTriggeredAbility(this);
}
}