Failure/foul-magics
1
0
Fork 0
forked from External/mage
Code Pull requests Releases Packages Activity Actions

refactor: ChoiceImpl constructor must specify whether required

Browse source 
changed a few others to required where clearly applicable
This commit is contained in:
xenohedron 2024-06-29 22:57:47 -04:00
parent bdeb4ed7ae
commit 9863e23435
27 changed files with 32 additions and 38 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Mage/src/main/java/mage/abilities/mana/CommanderColorIdentityManaAbility.java
View file

@ -106,7 +106,7 @@ class CommanderIdentityManaEffect extends ManaEffect {
}
Player controller = game.getPlayer(source.getControllerId());
if (controller != null) {
Choice choice = new ChoiceImpl().setManaColorChoice(true);
Choice choice = new ChoiceImpl(false).setManaColorChoice(true);
choice.setMessage("Pick a mana color");
for (UUID commanderId : game.getCommandersIds(controller, CommanderCardType.COMMANDER_OR_OATHBREAKER, false)) {
Card commander = game.getCard(commanderId);

4
Mage/src/main/java/mage/choices/ChoiceImpl.java
View file

@ -36,10 +36,6 @@ public class ChoiceImpl implements Choice {
protected boolean manaColorChoice = false; // set true to allow automatic choosing with Outcome.PutManaInPool
public ChoiceImpl() {
this(false);
}
public ChoiceImpl(boolean required) {
this(required, ChoiceHintType.TEXT);
}