refactor triggers checking batch damage for one player (#11435)

This commit is contained in:
xenohedron 2023-11-19 16:51:54 -05:00 committed by GitHub
parent d755e497cc
commit 8f89253b58
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 119 additions and 62 deletions

View file

@ -1,27 +1,15 @@
package mage.abilities.common;
import mage.abilities.TriggeredAbilityImpl;
import mage.abilities.effects.Effect;
import mage.constants.SetTargetPointer;
import mage.constants.Zone;
import mage.filter.StaticFilters;
import mage.filter.common.FilterCreaturePermanent;
import mage.game.Game;
import mage.game.events.DamagedBatchEvent;
import mage.game.events.DamagedEvent;
import mage.game.events.GameEvent;
import mage.game.permanent.Permanent;
import mage.target.targetpointer.FixedTarget;
import java.util.List;
import java.util.stream.Collectors;
/**
* @author LevelX2
* @author Xanderhall, xenohedron
*/
public class DealCombatDamageControlledTriggeredAbility extends TriggeredAbilityImpl {
private final SetTargetPointer setTargetPointer;
private final FilterCreaturePermanent filter;
public class DealCombatDamageControlledTriggeredAbility extends OneOrMoreDealDamageTriggeredAbility {
public DealCombatDamageControlledTriggeredAbility(Effect effect) {
this(effect, SetTargetPointer.NONE);
@ -35,57 +23,17 @@ public class DealCombatDamageControlledTriggeredAbility extends TriggeredAbility
this(Zone.BATTLEFIELD, effect, StaticFilters.FILTER_PERMANENT_CREATURES, setTargetPointer, false);
}
public DealCombatDamageControlledTriggeredAbility(Zone zone, Effect effect, FilterCreaturePermanent filter, SetTargetPointer setTargetPointer, boolean optional) {
super(zone, effect, optional);
this.setTargetPointer = setTargetPointer;
this.filter = filter;
String filterMessage = (filter.getMessage().contains("you control") ? filter.getMessage() : filter.getMessage() + " you control");
setTriggerPhrase("Whenever one or more " + filterMessage + " deal combat damage to a player, ");
public DealCombatDamageControlledTriggeredAbility(Zone zone, Effect effect, FilterCreaturePermanent filter,
SetTargetPointer setTargetPointer, boolean optional) {
super(zone, effect, filter, true, true, setTargetPointer, optional);
}
protected DealCombatDamageControlledTriggeredAbility(final DealCombatDamageControlledTriggeredAbility ability) {
super(ability);
this.setTargetPointer = ability.setTargetPointer;
this.filter = ability.filter;
}
@Override
public DealCombatDamageControlledTriggeredAbility copy() {
return new DealCombatDamageControlledTriggeredAbility(this);
}
@Override
public boolean checkEventType(GameEvent event, Game game) {
return event.getType() == GameEvent.EventType.DAMAGED_BATCH_FOR_ONE_PLAYER;
}
@Override
public boolean checkTrigger(GameEvent event, Game game) {
List<DamagedEvent> events = ((DamagedBatchEvent) event).getEvents().stream()
.filter(DamagedEvent::isCombatDamage)
.filter(e -> {
Permanent permanent = game.getPermanentOrLKIBattlefield(e.getSourceId());
return permanent != null
&& permanent.isControlledBy(this.getControllerId())
&& filter.match(permanent, game);
})
.collect(Collectors.toList());
if (events.isEmpty()) {
return false;
}
this.getEffects().setValue("damage", events.stream().mapToInt(DamagedEvent::getAmount).sum());
switch (setTargetPointer) {
case PLAYER:
this.getEffects().setTargetPointer(new FixedTarget(event.getPlayerId()));
break;
case NONE:
break;
default:
throw new IllegalArgumentException("Invalid SetTargetPointer option");
}
return true;
}
}