Failure/foul-magics
1
0
Fork 0
forked from External/mage
Code Pull requests Releases Packages Activity Actions

refactor: clean up static filters for sacrifice targets (#12120)

Browse source 
* simplify sacrifice target filters, part 1

* minor cleanup

* adjust SacrificeXTargetCost

* adjust Arctic Merfolk

* more cleanup

* remove unused

* adjust filters not used for sacrifice

* fix Hew the Entwood

* fix Nahiri's Lithoforming

* remove unused

* remove another

* cleanup more

* fix MegatronDestructiveForce

* remove next

* next batch of replacements

* remove next

* rename filter to match text

* finish removing

* use existing static filter
This commit is contained in:
xenohedron 2024-04-12 22:24:10 -04:00 • committed by GitHub
parent 5c9d1cd205
commit 8853e7d875
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
372 changed files with 489 additions and 712 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Mage/src/main/java/mage/abilities/costs/common/SacrificeXTargetCost.java
View file

@ -14,7 +14,7 @@ import mage.target.common.TargetSacrifice;
*/
public class SacrificeXTargetCost extends VariableCostImpl implements SacrificeCost {
protected final FilterPermanent filter;
private final FilterPermanent filter;
private final int minValue;
public SacrificeXTargetCost(FilterPermanent filter) {
@ -29,7 +29,7 @@ public class SacrificeXTargetCost extends VariableCostImpl implements SacrificeC
super(useAsAdditionalCost ? VariableCostType.ADDITIONAL : VariableCostType.NORMAL,
filter.getMessage() + " to sacrifice");
this.text = (useAsAdditionalCost ? "as an additional cost to cast this spell, sacrifice " : "Sacrifice ") + xText + ' ' + filter.getMessage();
this.filter = filter;
this.filter = TargetSacrifice.makeFilter(filter);
this.minValue = minValue;
}