Failure/foul-magics
1
0
Fork 0
forked from External/mage
Code Pull requests Releases Packages Activity Actions

refactor: some code linting (#10624)

Browse source 
* remove obsolete check method
* code clean: PermanentImpl
* code clean: PlayerImpl
* protected constructors in CardImpl
This commit is contained in:
xenohedron 2023-07-15 17:50:24 -04:00 • committed by GitHub
parent b960b77774
commit 8372c358b2
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 155 additions and 210 deletions
Download patch file Download diff file Expand all files Collapse all files

12
Mage/src/main/java/mage/cards/CardImpl.java
View file

@ -54,10 +54,10 @@ public abstract class CardImpl extends MageObjectImpl implements Card {
protected boolean morphCard;
protected List<UUID> attachments = new ArrayList<>();
public CardImpl(UUID ownerId, CardSetInfo setInfo, CardType[] cardTypes, String costs) {
protected CardImpl(UUID ownerId, CardSetInfo setInfo, CardType[] cardTypes, String costs) {
this(ownerId, setInfo, cardTypes, costs, SpellAbilityType.BASE);
}
public CardImpl(UUID ownerId, CardSetInfo setInfo, CardType[] cardTypes, String costs, SpellAbilityType spellAbilityType) {
protected CardImpl(UUID ownerId, CardSetInfo setInfo, CardType[] cardTypes, String costs, SpellAbilityType spellAbilityType) {
this(ownerId, setInfo.getName());
this.rarity = setInfo.getRarity();
@ -113,7 +113,7 @@ public abstract class CardImpl extends MageObjectImpl implements Card {
this.name = name;
}
public CardImpl(final CardImpl card) {
protected CardImpl(final CardImpl card) {
super(card);
ownerId = card.ownerId;
rarity = card.rarity;
@ -729,10 +729,8 @@ public abstract class CardImpl extends MageObjectImpl implements Card {
}
public boolean addCounters(Counter counter, UUID playerAddingCounters, Ability source, Game game, List<UUID> appliedEffects, boolean isEffect, int maxCounters) {
if (this instanceof Permanent) {
if (!((Permanent) this).isPhasedIn()) {
return false;
}
if (this instanceof Permanent && !((Permanent) this).isPhasedIn()) {
return false;
}
boolean returnCode = true;