[app-wiring-refactor]: Apply review comments:

- Add reference to original library in `FluentBuilder`.
- Change `I<Name>` notation to `<Name>Impl` notation.
- Move error config to test resources
- Add comment with config instruction
- Add config to the documentation
This commit is contained in:
Francesco Burato 2020-10-30 22:37:25 +00:00
parent e8bb8ae24b
commit 6e3750d50a
41 changed files with 171 additions and 146 deletions

View file

@ -9,7 +9,7 @@ import mage.view.ChatMessage;
import java.util.List;
import java.util.UUID;
public interface IChatManager {
public interface ChatManager {
UUID createChatSession(String info);
void joinChat(UUID chatId, UUID userId);

View file

@ -5,7 +5,7 @@ import mage.server.util.config.Plugin;
import java.util.List;
public interface IConfigSettings {
public interface ConfigSettings {
String getServerAddress();
String getServerName();

View file

@ -9,7 +9,7 @@ import java.util.Set;
import java.util.UUID;
import java.util.concurrent.ConcurrentHashMap;
public interface IDraftManager {
public interface DraftManager {
UUID createDraftSession(Draft draft, ConcurrentHashMap<UUID, UUID> userPlayerMap, UUID tableId);
void joinDraft(UUID draftId, UUID userId);

View file

@ -13,7 +13,7 @@ import java.util.Optional;
import java.util.UUID;
import java.util.concurrent.ConcurrentHashMap;
public interface IGameManager {
public interface GameManager {
UUID createGameSession(Game game, ConcurrentHashMap<UUID, UUID> userPlayerMap, UUID tableId, UUID choosingPlayerId, GameOptions gameOptions);
void joinGame(UUID gameId, UUID userId);

View file

@ -5,7 +5,7 @@ import mage.server.game.GamesRoom;
import java.util.Optional;
import java.util.UUID;
public interface IGamesRoomManager {
public interface GamesRoomManager {
UUID createRoom();
UUID getMainRoomId();

View file

@ -1,6 +1,6 @@
package mage.server.managers;
public interface IMailClient {
public interface MailClient {
boolean sendMessage(String email, String subject, String text);

View file

@ -1,29 +1,29 @@
package mage.server.managers;
public interface ManagerFactory {
IChatManager chatManager();
ChatManager chatManager();
IDraftManager draftManager();
DraftManager draftManager();
IGameManager gameManager();
GameManager gameManager();
IGamesRoomManager gamesRoomManager();
GamesRoomManager gamesRoomManager();
IMailClient mailClient();
MailClient mailClient();
IMailClient mailgunClient();
MailClient mailgunClient();
IReplayManager replayManager();
ReplayManager replayManager();
ISessionManager sessionManager();
SessionManager sessionManager();
ITableManager tableManager();
TableManager tableManager();
IUserManager userManager();
UserManager userManager();
IConfigSettings configSettings();
ConfigSettings configSettings();
IThreadExecutor threadExecutor();
ThreadExecutor threadExecutor();
ITournamentManager tournamentManager();
TournamentManager tournamentManager();
}

View file

@ -2,7 +2,7 @@ package mage.server.managers;
import java.util.UUID;
public interface IReplayManager {
public interface ReplayManager {
void replayGame(UUID gameId, UUID userId);
void startReplay(UUID gameId, UUID userId);

View file

@ -10,7 +10,7 @@ import org.jboss.remoting.callback.InvokerCallbackHandler;
import javax.annotation.Nonnull;
import java.util.Optional;
public interface ISessionManager {
public interface SessionManager {
Optional<Session> getSession(@Nonnull String sessionId);
void createSession(String sessionId, InvokerCallbackHandler callbackHandler);

View file

@ -17,7 +17,7 @@ import java.util.Collection;
import java.util.Optional;
import java.util.UUID;
public interface ITableManager {
public interface TableManager {
Table createTable(UUID roomId, UUID userId, MatchOptions options);
Table createTable(UUID roomId, MatchOptions options);

View file

@ -3,7 +3,7 @@ package mage.server.managers;
import java.util.concurrent.ExecutorService;
import java.util.concurrent.ScheduledExecutorService;
public interface IThreadExecutor {
public interface ThreadExecutor {
int getActiveThreads(ExecutorService executerService);
ExecutorService getCallExecutor();

View file

@ -9,7 +9,7 @@ import java.util.Optional;
import java.util.UUID;
import java.util.concurrent.ConcurrentHashMap;
public interface ITournamentManager {
public interface TournamentManager {
Optional<TournamentController> getTournamentController(UUID tournamentId);
void createTournamentSession(Tournament tournament, ConcurrentHashMap<UUID, UUID> userPlayerMap, UUID tableId);

View file

@ -10,7 +10,7 @@ import java.util.List;
import java.util.Optional;
import java.util.UUID;
public interface IUserManager {
public interface UserManager {
Optional<User> createUser(String userName, String host, AuthorizedUser authorizedUser);
Optional<User> getUser(UUID userId);