Failure/foul-magics
1
0
Fork 0
forked from External/mage
Code Pull requests Releases Packages Activity Actions

Tests: added verify check for wrong optional settings on DoIfCostPaid usage;

Browse source
This commit is contained in:
Oleg Agafonov 2020-08-14 16:22:34 +04:00
parent 9dc3d514bd
commit 61bfdf8108
2 changed files with 13 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

8
Mage/src/main/java/mage/abilities/TriggeredAbilityImpl.java
View file

@ -2,6 +2,7 @@ package mage.abilities;
import mage.MageObject;
import mage.abilities.effects.Effect;
import mage.abilities.effects.common.DoIfCostPaid;
import mage.constants.AbilityType;
import mage.constants.Zone;
import mage.game.Game;
@ -32,6 +33,13 @@ public abstract class TriggeredAbilityImpl extends AbilityImpl implements Trigge
addEffect(effect);
}
this.optional = optional;
// verify check: DoIfCostPaid effect already asks about action (optional), so no needs to ask it again in triggered ability
if (effect instanceof DoIfCostPaid) {
if (this.optional && ((DoIfCostPaid) effect).isOptional()) {
throw new IllegalArgumentException("DoIfCostPaid effect must have only one optional settings, but it have two (trigger + DoIfCostPaid): " + this.getClass().getSimpleName());
}
}
}
public TriggeredAbilityImpl(final TriggeredAbilityImpl ability) {