Failure/foul-magics
1
0
Fork 0
forked from External/mage
Code Pull requests Releases Packages Activity Actions

Fix auto-choose targets for activated abilities and spells (#13036)

Browse source 
* rework Armory Automaton

* remove redundant "setRequired(false)" from effects that separate into piles

* replace setRequired(false) with minTargets 0

* remove setRequired(false) where minTargets already 0

* remove setRequired(false) where preceded by chooseUse

* Revert "Player auto-choose respects required targets (#10557)"

This reverts commit fb8424556e.
This commit is contained in:
xenohedron 2024-10-26 20:23:50 -04:00 • committed by GitHub
parent 737e67963d
commit 5070f8bef7
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
19 changed files with 32 additions and 83 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Mage/src/main/java/mage/target/TargetImpl.java
View file

@ -370,7 +370,7 @@ public abstract class TargetImpl implements Target {
}
} else {
// Try to autochoosen
UUID autoChosenId = required ? tryToAutoChoose(playerId, source, game) : null;
UUID autoChosenId = tryToAutoChoose(playerId, source, game);
if (autoChosenId != null) {
addTarget(autoChosenId, source, game);
} else if (!targetController.chooseTarget(outcome, this, source, game)) { // If couldn't autochoose ask player