Failure/foul-magics
1
0
Fork 0
forked from External/mage
Code Pull requests Releases Packages Activity Actions

* Performance: memory usage optimization for deck editor (removed bloated usage of ManaCosts -> ManaColor objects, see #7515);

Browse source
This commit is contained in:
Oleg Agafonov 2021-02-12 14:08:17 +04:00
parent c3d55ea12a
commit 275e996c08
23 changed files with 170 additions and 143 deletions
Download patch file Download diff file Expand all files Collapse all files

30
Mage/src/main/java/mage/Mana.java
View file

@ -24,6 +24,10 @@ public class Mana implements Comparable<Mana>, Serializable, Copyable<Mana> {
private ManaColor() {
}
protected ManaColor(final ManaColor manaColor) {
this.copyFrom(manaColor);
}
private ManaColor(int amount) {
this.amount = amount;
}
@ -76,9 +80,12 @@ public class Mana implements Comparable<Mana>, Serializable, Copyable<Mana> {
}
protected ManaColor copy() {
ManaColor copy = new ManaColor();
copy.incrementAmount(this);
return copy;
return new ManaColor(this);
}
protected void copyFrom(final ManaColor manaColor) {
this.amount = manaColor.amount;
this.snowAmount = manaColor.snowAmount;
}
@Override
@ -1202,14 +1209,15 @@ public class Mana implements Comparable<Mana>, Serializable, Copyable<Mana> {
* @param mana the mana to set this object to.
*/
public void setToMana(final Mana mana) {
this.any = mana.any.copy();
this.white = mana.white.copy();
this.blue = mana.blue.copy();
this.black = mana.black.copy();
this.red = mana.red.copy();
this.green = mana.green.copy();
this.colorless = mana.colorless.copy();
this.generic = mana.generic.copy();
this.any.copyFrom(mana.any);
this.white.copyFrom(mana.white);
this.blue.copyFrom(mana.blue.copy());
this.black.copyFrom(mana.black.copy());
this.red.copyFrom(mana.red.copy());
this.green.copyFrom(mana.green.copy());
this.colorless.copyFrom(mana.colorless.copy());
this.generic.copyFrom(mana.generic.copy());
//this.flag = mana.flag;
}
/**