cleanup: CardsImpl and related (#11585)

* minor cleanup of unused params in ExileZone

* cleanup CardsImpl

standardize logic for different methods

remove unused ownerId param
This commit is contained in:
xenohedron 2023-12-29 22:39:56 -05:00 committed by GitHub
parent f8ed194028
commit 1bdacc6676
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
6 changed files with 34 additions and 69 deletions

View file

@ -9,32 +9,20 @@ import java.util.UUID;
*/
public class ExileZone extends CardsImpl {
private UUID id;
private String name;
private boolean hidden;
private final UUID id;
private final String name;
private boolean cleanupOnEndTurn = false; // moved cards from that zone to default on end of turn (to cleanup exile windows)
public ExileZone(UUID id, String name) {
this(id, name, false);
}
public ExileZone(UUID id, String name, boolean hidden) {
this(id, name, false, false);
}
public ExileZone(UUID id, String name, boolean hidden, boolean cleanupOnEndTurn) {
super();
this.id = id;
this.name = name;
this.hidden = hidden;
this.cleanupOnEndTurn = cleanupOnEndTurn;
}
protected ExileZone(final ExileZone zone) {
super(zone);
this.id = zone.id;
this.name = zone.name;
this.hidden = zone.hidden;
this.cleanupOnEndTurn = zone.cleanupOnEndTurn;
}
@ -46,10 +34,6 @@ public class ExileZone extends CardsImpl {
return name;
}
public boolean isHidden() {
return hidden;
}
public boolean isCleanupOnEndTurn() {
return cleanupOnEndTurn;
}