diff --git a/Mage.Sets/src/mage/cards/g/GenesisOfTheDaleks.java b/Mage.Sets/src/mage/cards/g/GenesisOfTheDaleks.java index daef4301cea..6807307ac58 100644 --- a/Mage.Sets/src/mage/cards/g/GenesisOfTheDaleks.java +++ b/Mage.Sets/src/mage/cards/g/GenesisOfTheDaleks.java @@ -2,8 +2,7 @@ package mage.cards.g; import mage.abilities.Ability; import mage.abilities.common.SagaAbility; -import mage.abilities.dynamicvalue.DynamicValue; -import mage.abilities.effects.Effect; +import mage.abilities.dynamicvalue.common.CountersSourceCount; import mage.abilities.effects.OneShotEffect; import mage.abilities.effects.common.CreateTokenEffect; import mage.abilities.effects.common.DestroyAllEffect; @@ -19,7 +18,6 @@ import mage.filter.predicate.Predicates; import mage.game.Game; import mage.game.events.GameEvent; import mage.game.events.ZoneChangeEvent; -import mage.game.permanent.Permanent; import mage.game.permanent.token.DalekToken; import mage.players.Player; import mage.target.common.TargetOpponent; @@ -44,7 +42,7 @@ public final class GenesisOfTheDaleks extends CardImpl { // I, II, III -- Create a 3/3 black Dalek artifact creature token with menace for each lore counter on Genesis of the Daleks. sagaAbility.addChapterEffect( this, SagaChapter.CHAPTER_I, SagaChapter.CHAPTER_III, - new CreateTokenEffect(new DalekToken(), GenesisOfTheDaleksValue.instance) + new CreateTokenEffect(new DalekToken(), new CountersSourceCount(CounterType.LORE)) ); // IV -- Target opponent faces a villainous choice -- Destroy all Dalek creatures and each of your opponents loses life equal to the total power of Daleks that died this turn, or destroy all non-Dalek creatures. @@ -65,41 +63,6 @@ public final class GenesisOfTheDaleks extends CardImpl { } } -enum GenesisOfTheDaleksValue implements DynamicValue { - instance; - - @Override - public int calculate(Game game, Ability sourceAbility, Effect effect) { - Permanent permanent = sourceAbility.getSourcePermanentOrLKI(game); - if (permanent != null) { - return permanent - .getCounters(game) - .getCount(CounterType.LORE); - } - return Optional - .ofNullable(sourceAbility) - .map(Ability::getSourceId) - .map(game::getPermanentOrLKIBattlefield) - .map(p -> p.getCounters(game).getCount(CounterType.LORE)) - .orElse(0); - } - - @Override - public GenesisOfTheDaleksValue copy() { - return this; - } - - @Override - public String getMessage() { - return "lore counter on {this}"; - } - - @Override - public String toString() { - return "1"; - } -} - class GenesisOfTheDaleksEffect extends OneShotEffect { private static final FaceVillainousChoice choice = new FaceVillainousChoice( diff --git a/Mage.Sets/src/mage/cards/l/LongListOfTheEnts.java b/Mage.Sets/src/mage/cards/l/LongListOfTheEnts.java index 95abf6d63d5..0bb6414a7a7 100644 --- a/Mage.Sets/src/mage/cards/l/LongListOfTheEnts.java +++ b/Mage.Sets/src/mage/cards/l/LongListOfTheEnts.java @@ -53,8 +53,8 @@ public final class LongListOfTheEnts extends CardImpl { return new LongListOfTheEnts(this); } - static String getKey(Game game, Ability source, int offset) { - return "EntList_" + source.getSourceId() + "_" + (offset + CardUtil.getActualSourceObjectZoneChangeCounter(game, source)); + static String getKey(Game game, Ability source) { + return "EntList_" + source.getSourceId() + "_" + CardUtil.getActualSourceObjectZoneChangeCounter(game, source); } } @@ -67,7 +67,7 @@ enum LongListOfTheEntsHint implements Hint { if (ability.getSourcePermanentIfItStillExists(game) == null) { return null; } - Set subTypes = (Set) game.getState().getValue(LongListOfTheEnts.getKey(game, ability, 0)); + Set subTypes = (Set) game.getState().getValue(LongListOfTheEnts.getKey(game, ability)); if (subTypes == null || subTypes.isEmpty()) { return "No creature types have been noted yet."; } @@ -109,14 +109,11 @@ class LongListOfTheEntsEffect extends OneShotEffect { return false; } - Object existingEntList = game.getState().getValue(LongListOfTheEnts.getKey(game, source, 0)); - int offset; + Object existingEntList = game.getState().getValue(LongListOfTheEnts.getKey(game, source)); Set newEntList; if (existingEntList == null) { - offset = 1; // zcc is off-by-one due to still entering battlefield newEntList = new LinkedHashSet<>(); } else { - offset = 0; newEntList = new LinkedHashSet<>((Set) existingEntList); } Set chosenTypes = newEntList @@ -132,7 +129,7 @@ class LongListOfTheEntsEffect extends OneShotEffect { SubType subType = SubType.byDescription(choice.getChoiceKey()); game.informPlayers(player.getLogName() + " notes the creature type " + subType); newEntList.add(subType); - game.getState().setValue(LongListOfTheEnts.getKey(game, source, offset), newEntList); + game.getState().setValue(LongListOfTheEnts.getKey(game, source), newEntList); FilterSpell filter = new FilterCreatureSpell("a creature spell of that type"); filter.add(subType.getPredicate()); game.addDelayedTriggeredAbility(new AddCounterNextSpellDelayedTriggeredAbility(filter), source); diff --git a/Mage.Sets/src/mage/cards/s/SummonEsperValigarmanda.java b/Mage.Sets/src/mage/cards/s/SummonEsperValigarmanda.java index 3a2c1b4614a..3fcc14c2c8e 100644 --- a/Mage.Sets/src/mage/cards/s/SummonEsperValigarmanda.java +++ b/Mage.Sets/src/mage/cards/s/SummonEsperValigarmanda.java @@ -107,7 +107,7 @@ class SummonEsperValigarmandaExileEffect extends OneShotEffect { return !cards.isEmpty() && controller.moveCardsToExile( cards.getCards(game), source, game, true, - CardUtil.getExileZoneId(game, source, 1), + CardUtil.getExileZoneId(game, source), CardUtil.getSourceName(game, source) ); } diff --git a/Mage.Sets/src/mage/cards/t/TheAesirEscapeValhalla.java b/Mage.Sets/src/mage/cards/t/TheAesirEscapeValhalla.java index 0095d30b9ae..aed85868cd2 100644 --- a/Mage.Sets/src/mage/cards/t/TheAesirEscapeValhalla.java +++ b/Mage.Sets/src/mage/cards/t/TheAesirEscapeValhalla.java @@ -1,15 +1,13 @@ package mage.cards.t; -import java.util.UUID; - import mage.MageObject; import mage.abilities.Ability; import mage.abilities.common.SagaAbility; import mage.abilities.effects.OneShotEffect; import mage.cards.Card; -import mage.constants.*; import mage.cards.CardImpl; import mage.cards.CardSetInfo; +import mage.constants.*; import mage.counters.CounterType; import mage.filter.StaticFilters; import mage.game.ExileZone; @@ -20,6 +18,8 @@ import mage.target.common.TargetCardInGraveyard; import mage.target.common.TargetControlledCreaturePermanent; import mage.util.CardUtil; +import java.util.UUID; + /** * * @author Grath @@ -83,7 +83,7 @@ class TheAesirEscapeValhallaOneEffect extends OneShotEffect { controller.choose(outcome, target, source, game); Card card = game.getCard(target.getFirstTarget()); if (card != null) { - UUID exileId = CardUtil.getExileZoneId(game, source, 1); + UUID exileId = CardUtil.getExileZoneId(game, source); MageObject sourceObject = source.getSourceObject(game); String exileName = sourceObject != null ? sourceObject.getName() : ""; controller.moveCardsToExile(card, source, game, false, exileId, exileName); diff --git a/Mage.Sets/src/mage/cards/t/TheCreationOfAvacyn.java b/Mage.Sets/src/mage/cards/t/TheCreationOfAvacyn.java index 17b28d39754..b1cdb9ab468 100644 --- a/Mage.Sets/src/mage/cards/t/TheCreationOfAvacyn.java +++ b/Mage.Sets/src/mage/cards/t/TheCreationOfAvacyn.java @@ -81,7 +81,7 @@ class TheCreationOfAvacynOneEffect extends OneShotEffect { if (card != null) { // exile it face down card.setFaceDown(true, game); - UUID exileId = CardUtil.getExileZoneId(game, source, 1); + UUID exileId = CardUtil.getExileZoneId(game, source); MageObject sourceObject = source.getSourceObject(game); String exileName = sourceObject != null ? sourceObject.getName() : ""; controller.moveCardsToExile(card, source, game, false, exileId, exileName); diff --git a/Mage.Tests/src/test/java/org/mage/test/cards/single/cmm/BattleAtTheHelvaultTest.java b/Mage.Tests/src/test/java/org/mage/test/cards/single/cmm/BattleAtTheHelvaultTest.java index 03327878361..858946e2128 100644 --- a/Mage.Tests/src/test/java/org/mage/test/cards/single/cmm/BattleAtTheHelvaultTest.java +++ b/Mage.Tests/src/test/java/org/mage/test/cards/single/cmm/BattleAtTheHelvaultTest.java @@ -2,7 +2,6 @@ package org.mage.test.cards.single.cmm; import mage.constants.PhaseStep; import mage.constants.Zone; -import org.junit.Ignore; import org.junit.Test; import org.mage.test.serverside.base.CardTestPlayerBase; @@ -19,7 +18,6 @@ public class BattleAtTheHelvaultTest extends CardTestPlayerBase { */ private static final String battle = "Battle at the Helvault"; - @Ignore // TODO: goal of #11619 is to fix this nicely @Test public void test_SimplePlay() { addCard(Zone.HAND, playerA, battle, 1); diff --git a/Mage.Tests/src/test/java/org/mage/test/cards/single/fic/SummonIxionTest.java b/Mage.Tests/src/test/java/org/mage/test/cards/single/fic/SummonIxionTest.java index 82fb895ccce..527cba0941b 100644 --- a/Mage.Tests/src/test/java/org/mage/test/cards/single/fic/SummonIxionTest.java +++ b/Mage.Tests/src/test/java/org/mage/test/cards/single/fic/SummonIxionTest.java @@ -3,7 +3,6 @@ package org.mage.test.cards.single.fic; import mage.constants.PhaseStep; import mage.constants.Zone; import mage.counters.CounterType; -import org.junit.Ignore; import org.junit.Test; import org.mage.test.player.TestPlayer; import org.mage.test.serverside.base.CardTestPlayerBase; @@ -23,7 +22,6 @@ public class SummonIxionTest extends CardTestPlayerBase { */ private static final String ixion = "Summon: Ixion"; - @Ignore // TODO: goal of #11619 is to fix this nicely @Test public void test_SimplePlay() { addCard(Zone.HAND, playerA, ixion, 1); diff --git a/Mage.Tests/src/test/java/org/mage/test/cards/single/pip/Vault13DwellersJourneyTest.java b/Mage.Tests/src/test/java/org/mage/test/cards/single/pip/Vault13DwellersJourneyTest.java index 16b0a3f9ae9..b5ddd69b912 100644 --- a/Mage.Tests/src/test/java/org/mage/test/cards/single/pip/Vault13DwellersJourneyTest.java +++ b/Mage.Tests/src/test/java/org/mage/test/cards/single/pip/Vault13DwellersJourneyTest.java @@ -2,7 +2,6 @@ package org.mage.test.cards.single.pip; import mage.constants.PhaseStep; import mage.constants.Zone; -import org.junit.Ignore; import org.junit.Test; import org.mage.test.player.TestPlayer; import org.mage.test.serverside.base.CardTestPlayerBase; @@ -21,7 +20,6 @@ public class Vault13DwellersJourneyTest extends CardTestPlayerBase { */ private static final String vault = "Vault 13: Dweller's Journey"; - @Ignore // TODO: goal of #11619 is to fix this nicely @Test public void test_SimplePlay_ReturnOne() { addCard(Zone.HAND, playerA, vault, 1); @@ -49,7 +47,6 @@ public class Vault13DwellersJourneyTest extends CardTestPlayerBase { assertPermanentCount(playerA, "Memnite", 1); assertLife(playerA, 20 + 2); } - @Ignore // TODO: goal of #11619 is to fix this nicely @Test public void test_SimplePlay_Return() { addCard(Zone.HAND, playerA, vault, 1); @@ -81,7 +78,6 @@ public class Vault13DwellersJourneyTest extends CardTestPlayerBase { assertLife(playerA, 20 + 2); } - @Ignore // TODO: goal of #11619 is to fix this nicely @Test public void test_SimplePlay_NoReturn() { addCard(Zone.HAND, playerA, vault, 1); diff --git a/Mage.Tests/src/test/java/org/mage/test/cards/single/who/DayOfTheMoonTest.java b/Mage.Tests/src/test/java/org/mage/test/cards/single/who/DayOfTheMoonTest.java index bd0c49f72d1..97d1072d424 100644 --- a/Mage.Tests/src/test/java/org/mage/test/cards/single/who/DayOfTheMoonTest.java +++ b/Mage.Tests/src/test/java/org/mage/test/cards/single/who/DayOfTheMoonTest.java @@ -2,7 +2,6 @@ package org.mage.test.cards.single.who; import mage.constants.PhaseStep; import mage.constants.Zone; -import org.junit.Ignore; import org.junit.Test; import org.mage.test.serverside.base.CardTestPlayerBase; @@ -18,7 +17,6 @@ public class DayOfTheMoonTest extends CardTestPlayerBase { */ private static final String day = "Day of the Moon"; - @Ignore // TODO: goal of #11619 is to fix this nicely @Test public void test_SimplePlay() { addCard(Zone.HAND, playerA, day, 1); diff --git a/Mage.Tests/src/test/java/org/mage/test/cards/single/who/TheWarGamesTest.java b/Mage.Tests/src/test/java/org/mage/test/cards/single/who/TheWarGamesTest.java index 7bddf646de1..8f5d72293c6 100644 --- a/Mage.Tests/src/test/java/org/mage/test/cards/single/who/TheWarGamesTest.java +++ b/Mage.Tests/src/test/java/org/mage/test/cards/single/who/TheWarGamesTest.java @@ -2,7 +2,6 @@ package org.mage.test.cards.single.who; import mage.constants.PhaseStep; import mage.constants.Zone; -import org.junit.Ignore; import org.junit.Test; import org.mage.test.serverside.base.CardTestPlayerBase; @@ -20,7 +19,6 @@ public class TheWarGamesTest extends CardTestPlayerBase { */ private static final String war = "The War Games"; - @Ignore // TODO: goal of #11619 is to fix this nicely @Test public void test_SimplePlay_NoExile() { addCard(Zone.HAND, playerA, war, 1); @@ -63,7 +61,6 @@ public class TheWarGamesTest extends CardTestPlayerBase { assertLife(playerB, 20 - 6 - 9); } - @Ignore // TODO: goal of #11619 is to fix this nicely @Test public void test_SimplePlay_Exile() { addCard(Zone.HAND, playerA, war, 1); diff --git a/Mage.Tests/src/test/java/org/mage/test/cards/single/who/TrialOfATimeLordTest.java b/Mage.Tests/src/test/java/org/mage/test/cards/single/who/TrialOfATimeLordTest.java index 09ae8e86c72..7653a1e1a33 100644 --- a/Mage.Tests/src/test/java/org/mage/test/cards/single/who/TrialOfATimeLordTest.java +++ b/Mage.Tests/src/test/java/org/mage/test/cards/single/who/TrialOfATimeLordTest.java @@ -2,7 +2,6 @@ package org.mage.test.cards.single.who; import mage.constants.PhaseStep; import mage.constants.Zone; -import org.junit.Ignore; import org.junit.Test; import org.mage.test.serverside.base.CardTestPlayerBase; @@ -20,7 +19,6 @@ public class TrialOfATimeLordTest extends CardTestPlayerBase { */ private static final String trial = "Trial of a Time Lord"; - @Ignore // TODO: goal of #11619 is to fix this nicely @Test public void test_SimplePlay() { addCard(Zone.HAND, playerA, trial, 1); diff --git a/Mage.Tests/src/test/java/org/mage/test/cards/single/woe/ThePrincessTakesFlightTest.java b/Mage.Tests/src/test/java/org/mage/test/cards/single/woe/ThePrincessTakesFlightTest.java index e7b9d197590..5fe5879fa96 100644 --- a/Mage.Tests/src/test/java/org/mage/test/cards/single/woe/ThePrincessTakesFlightTest.java +++ b/Mage.Tests/src/test/java/org/mage/test/cards/single/woe/ThePrincessTakesFlightTest.java @@ -3,7 +3,6 @@ package org.mage.test.cards.single.woe; import mage.abilities.keyword.FlyingAbility; import mage.constants.PhaseStep; import mage.constants.Zone; -import org.junit.Ignore; import org.junit.Test; import org.mage.test.serverside.base.CardTestPlayerBase; @@ -21,7 +20,6 @@ public class ThePrincessTakesFlightTest extends CardTestPlayerBase { */ private static final String flight = "The Princess Takes Flight"; - @Ignore // TODO: goal of #11619 is to fix this nicely @Test public void test_SimplePlay() { addCard(Zone.HAND, playerA, flight, 1); @@ -54,7 +52,6 @@ public class ThePrincessTakesFlightTest extends CardTestPlayerBase { assertExileCount(playerB, "Memnite", 0); assertPermanentCount(playerB, "Memnite", 1); } - @Ignore // TODO: goal of #11619 is to fix this nicely @Test public void testFlicker() { addCard(Zone.BATTLEFIELD, playerA, "Plains", 5); diff --git a/Mage/src/main/java/mage/abilities/AbilityImpl.java b/Mage/src/main/java/mage/abilities/AbilityImpl.java index 50340177526..dd566fe4834 100644 --- a/Mage/src/main/java/mage/abilities/AbilityImpl.java +++ b/Mage/src/main/java/mage/abilities/AbilityImpl.java @@ -1707,15 +1707,14 @@ public abstract class AbilityImpl implements Ability { private int getCurrentSourceObjectZoneChangeCounter(Game game){ int zcc = game.getState().getZoneChangeCounter(getSourceId()); - // TODO: Enable this, #13710 - /*if (game.getPermanentEntering(getSourceId()) != null){ + if (game.getPermanentEntering(getSourceId()) != null){ // If the triggered ability triggered while the permanent is entering the battlefield // then add 1 zcc so that it triggers as if the permanent was already on the battlefield // So "Enters with counters" causes "Whenever counters are placed" to trigger with battlefield zcc // Particularly relevant for Sagas, which always involve both // Note that this does NOT apply to "As ~ ETB" effects, those still use the stack zcc zcc += 1; - }*/ + } return zcc; }