From 0ebd265197cdb9104e691549e4d91fe7fe68860f Mon Sep 17 00:00:00 2001
From: LevelX2 <ludwig.hirth@online.de>
Date: Sat, 13 Apr 2013 18:18:24 +0200
Subject: [PATCH] Fixed a bug, that a ability gained to multiple permanents
 (e.g. Forestwalk) was only gained to the first permanent because no uniquie
 id was set for the copied ability added to state. Added a test for the bug.

---
 .../ElvishChampionForestwalkTest.java         | 78 +++++++++++++++++++
 .../mage/game/permanent/PermanentImpl.java    |  1 +
 2 files changed, 79 insertions(+)
 create mode 100644 Mage.Tests/src/test/java/org/mage/test/cards/restriction/ElvishChampionForestwalkTest.java

diff --git a/Mage.Tests/src/test/java/org/mage/test/cards/restriction/ElvishChampionForestwalkTest.java b/Mage.Tests/src/test/java/org/mage/test/cards/restriction/ElvishChampionForestwalkTest.java
new file mode 100644
index 00000000000..7e140d82009
--- /dev/null
+++ b/Mage.Tests/src/test/java/org/mage/test/cards/restriction/ElvishChampionForestwalkTest.java
@@ -0,0 +1,78 @@
+/*
+ *  Copyright 2010 BetaSteward_at_googlemail.com. All rights reserved.
+ *
+ *  Redistribution and use in source and binary forms, with or without modification, are
+ *  permitted provided that the following conditions are met:
+ *
+ *     1. Redistributions of source code must retain the above copyright notice, this list of
+ *        conditions and the following disclaimer.
+ *
+ *     2. Redistributions in binary form must reproduce the above copyright notice, this list
+ *        of conditions and the following disclaimer in the documentation and/or other materials
+ *        provided with the distribution.
+ *
+ *  THIS SOFTWARE IS PROVIDED BY BetaSteward_at_googlemail.com ``AS IS'' AND ANY EXPRESS OR IMPLIED
+ *  WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND
+ *  FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL BetaSteward_at_googlemail.com OR
+ *  CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
+ *  CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR
+ *  SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON
+ *  ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING
+ *  NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF
+ *  ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+ *
+ *  The views and conclusions contained in the software and documentation are those of the
+ *  authors and should not be interpreted as representing official policies, either expressed
+ *  or implied, of BetaSteward_at_googlemail.com.
+ */
+
+package org.mage.test.cards.restriction;
+
+import mage.Constants;
+import org.junit.Test;
+import org.mage.test.serverside.base.CardTestPlayerBase;
+
+/**
+ *
+ * @author LevelX2
+ */
+
+/*
+ *  Elvish Champion
+ *  Creature — Elf 2/2, 1GG
+ *  Other Elf creatures get +1/+1 and have forestwalk. (They're unblockable as long as defending player controls a Forest.)
+ */
+
+public class ElvishChampionForestwalkTest extends CardTestPlayerBase {
+
+    /**
+     * Tests "If all other elves get the Forestwalk ability and can't be blockt from creatures whose controler has a forest in game"
+     */
+
+    @Test
+    public void testCannotBlockCreatureWithForestwalk() {
+        addCard(Constants.Zone.BATTLEFIELD, playerA, "Elvish Champion");
+        addCard(Constants.Zone.BATTLEFIELD, playerA, "Arbor Elf");
+        addCard(Constants.Zone.BATTLEFIELD, playerA, "Defiant Elf");
+
+        addCard(Constants.Zone.BATTLEFIELD, playerB, "Forest");
+        addCard(Constants.Zone.BATTLEFIELD, playerB, "Silvercoat Lion");
+        addCard(Constants.Zone.BATTLEFIELD, playerB, "Canyon Minotaur");
+
+        attack(3, playerA, "Arbor Elf");
+        attack(3, playerA, "Defiant Elf");
+        block(3, playerB, "Silvercoat Lion", "Arbor Elf");
+        block(3, playerB, "Canyon Minotaur", "Defiant Elf");
+
+        setStopAt(3, Constants.PhaseStep.POSTCOMBAT_MAIN);
+        execute();
+
+        assertPermanentCount(playerA, "Arbor Elf", 1);
+        assertPermanentCount(playerA, "Defiant Elf", 1);
+
+        assertLife(playerA, 20);
+        assertLife(playerB, 16);
+
+    }
+
+}
diff --git a/Mage/src/mage/game/permanent/PermanentImpl.java b/Mage/src/mage/game/permanent/PermanentImpl.java
index 21fe11d5225..28533a32319 100644
--- a/Mage/src/mage/game/permanent/PermanentImpl.java
+++ b/Mage/src/mage/game/permanent/PermanentImpl.java
@@ -187,6 +187,7 @@ public abstract class PermanentImpl<T extends PermanentImpl<T>> extends CardImpl
     public void addAbility(Ability ability, UUID sourceId, Game game) {
         if (!abilities.containsKey(ability.getId())) {
             Ability copyAbility = ability.copy();
+            copyAbility.newId(); // needed e.g. if a gainAll ability gives Forestwalk to multiple creatures
             copyAbility.setControllerId(controllerId);
             copyAbility.setSourceId(objectId);
             game.getState().addAbility(copyAbility, sourceId, this);