Failure/foul-magics
1
0
Fork 0
forked from External/mage
Code Pull requests Releases Packages Activity Actions

backup ability: fixed wrong duration and discard in Streetwise Negotiator, added related tests and runtime/verify checks (related to #11068)

Browse source
This commit is contained in:
Oleg Agafonov 2023-08-31 07:27:59 +04:00
parent 9085820605
commit 060b8f9dc9
5 changed files with 43 additions and 15 deletions
Download patch file Download diff file Expand all files Collapse all files

19
Mage/src/main/java/mage/abilities/keyword/BackupAbility.java
View file

@ -1,10 +1,14 @@
package mage.abilities.keyword;
import mage.abilities.Ability;
import mage.abilities.StaticAbility;
import mage.abilities.common.EntersBattlefieldTriggeredAbility;
import mage.abilities.effects.ContinuousEffect;
import mage.abilities.effects.Effect;
import mage.abilities.effects.OneShotEffect;
import mage.abilities.effects.common.continuous.GainAbilityTargetEffect;
import mage.cards.Card;
import mage.constants.Duration;
import mage.constants.Outcome;
import mage.counters.CounterType;
import mage.game.Game;
@ -85,12 +89,25 @@ public class BackupAbility extends EntersBattlefieldTriggeredAbility {
}
/**
*
* @param ability
* @param watcher
* @param dontAddToCard use it on multiple instances of backups (example: Conclave Sledge-Captain)
*/
public void addAbility(Ability ability, Watcher watcher, boolean dontAddToCard) {
// runtime/verify check: wrong duration in backup's static effects
if (ability instanceof StaticAbility) {
Effect wrongEffect = ability.getEffects().stream()
.filter(effect -> effect instanceof ContinuousEffect)
.map(effect -> (ContinuousEffect) effect)
.filter(effect -> effect.getDuration().equals(Duration.EndOfTurn))
.findFirst()
.orElse(null);
if (wrongEffect != null) {
// how-to fix: add effect with Duration.EndOfGame (backup's abilities for permanent controls by GainAbility)
throw new IllegalArgumentException("Wrong code usage. Backup ability and source card must contains static effects. Wrong effect: " + wrongEffect.getClass().getName());
}
}
if (watcher != null) {
ability.addWatcher(watcher);
}