Failure/foul-magics
1
0
Fork 0
forked from External/mage
Code Pull requests Releases Packages Activity Actions

[BRC] Implement Rootpath Purifier (ready for review) (#10363)

Browse source 
* refactor check supertype methods

* change supertype to list to match card type

* refactor various subtype methods

* implement mageobjectattribute for supertype

* a few fixes

* [BRC] Implement Rootpath Purifier

* a few extra fixes

* more fixes

* add test for purifier
This commit is contained in:
Evan Kranzler 2023-05-13 10:48:07 -04:00 • committed by GitHub
parent a850e3660b
commit 024c3081df
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
98 changed files with 489 additions and 238 deletions
Download patch file Download diff file Expand all files Collapse all files

9
Mage.Verify/src/test/java/mage/verify/VerifyCardDataTest.java
View file

@ -20,7 +20,6 @@ import mage.cards.repository.*;
import mage.constants.CardType;
import mage.constants.Rarity;
import mage.constants.SubType;
import mage.constants.SuperType;
import mage.game.command.Dungeon;
import mage.game.command.Plane;
import mage.game.draft.DraftCube;
@ -1064,7 +1063,7 @@ public class VerifyCardDataTest {
}
// CHECK: all planeswalkers must be legendary
if (card.isPlaneswalker() && !card.getSuperType().contains(SuperType.LEGENDARY)) {
if (card.isPlaneswalker() && !card.isLegendary()) {
errorsList.add("Error: planeswalker must have legendary type: " + set.getCode() + " - " + set.getName() + " - " + card.getName() + " - " + card.getCardNumber());
}
@ -2248,12 +2247,12 @@ public class VerifyCardDataTest {
fail(card, "rarity", "basic land must be Rarity.LAND");
}
if (!card.getSuperType().contains(SuperType.BASIC)) {
if (!card.isBasic()) {
fail(card, "supertype", "basic land must be SuperType.BASIC");
}
} else if (name.equals("Wastes")) {
// Wastes are SuperType.BASIC but not necessarily Rarity.LAND
if (!card.getSuperType().contains(SuperType.BASIC)) {
if (!card.isBasic()) {
fail(card, "supertype", "Wastes must be SuperType.BASIC");
}
} else {
@ -2262,7 +2261,7 @@ public class VerifyCardDataTest {
fail(card, "rarity", "only basic land can be Rarity.LAND");
}
if (card.getSuperType().contains(SuperType.BASIC)) {
if (card.isBasic()) {
fail(card, "supertype", "only basic land can be SuperType.BASIC");
}
}