Failure/foul-magics
1
0
Fork 0
forked from External/mage
Code Pull requests Releases Packages Activity Actions

[LTR] Implement Shelob, Child of Ungoliant (#10558)

Browse source 
* [LTR] Implement Shelob, Child of Ungoliant

This is almost working.

I could not figure out why, but tokens made with the trigger still have subtypes, even though it has only artifact as its type.

* fix subtype of the token copy not being cleaned.

fixed Myrkul, Lord of Bones that had the same issue.
removed game argument from CreateTokenCopyTargetEffect's PermanentModifier. It was only used by Myrkul, and with no effect.
This commit is contained in:
Susucre 2023-07-06 01:21:52 +02:00 • committed by GitHub
parent 476fd27f65
commit 008662be5e
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
8 changed files with 253 additions and 14 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Mage/src/main/java/mage/abilities/effects/common/CreateTokenCopyTargetEffect.java
View file

@ -34,7 +34,7 @@ public class CreateTokenCopyTargetEffect extends OneShotEffect {
@FunctionalInterface
public interface PermanentModifier {
void apply(Token token, Game game);
void apply(Token token);
}
private final Set<Class<? extends Ability>> abilityClazzesToRemove;
@ -241,7 +241,7 @@ public class CreateTokenCopyTargetEffect extends OneShotEffect {
}
additionalAbilities.stream().forEach(token::addAbility);
if (permanentModifier != null) {
permanentModifier.apply(token, game);
permanentModifier.apply(token);
}
if (!this.abilityClazzesToRemove.isEmpty()) {