mediamtx/internal/stream/stream_format.go
Alessandro Ros 986e270862
Some checks are pending
code_lint / golangci_lint (push) Waiting to run
code_lint / mod_tidy (push) Waiting to run
code_lint / api_docs (push) Waiting to run
code_test / test_64 (push) Waiting to run
code_test / test_32 (push) Waiting to run
code_test / test_highlevel (push) Waiting to run
count and log all discarded frames, decode errors, lost packets (#4363)
Discarded frames, decode errors and lost packets were logged
individually, then there was a mechanism that prevented more than 1 log
entry per second from being printed, resulting in inaccurate reports.

Now discarded frames, decode errors and lost packets are accurately
counted, and their count is printed once every second.
2025-03-25 21:59:58 +01:00

116 lines
2.6 KiB
Go

package stream
import (
"sync/atomic"
"time"
"github.com/bluenviron/gortsplib/v4/pkg/description"
"github.com/bluenviron/gortsplib/v4/pkg/format"
"github.com/pion/rtp"
"github.com/bluenviron/mediamtx/internal/counterdumper"
"github.com/bluenviron/mediamtx/internal/formatprocessor"
"github.com/bluenviron/mediamtx/internal/unit"
)
func unitSize(u unit.Unit) uint64 {
n := uint64(0)
for _, pkt := range u.GetRTPPackets() {
n += uint64(pkt.MarshalSize())
}
return n
}
type streamFormat struct {
UDPMaxPayloadSize int
Format format.Format
GenerateRTPPackets bool
DecodeErrors *counterdumper.CounterDumper
proc formatprocessor.Processor
pausedReaders map[*streamReader]ReadFunc
runningReaders map[*streamReader]ReadFunc
}
func (sf *streamFormat) initialize() error {
sf.pausedReaders = make(map[*streamReader]ReadFunc)
sf.runningReaders = make(map[*streamReader]ReadFunc)
var err error
sf.proc, err = formatprocessor.New(sf.UDPMaxPayloadSize, sf.Format, sf.GenerateRTPPackets)
if err != nil {
return err
}
return nil
}
func (sf *streamFormat) addReader(sr *streamReader, cb ReadFunc) {
sf.pausedReaders[sr] = cb
}
func (sf *streamFormat) removeReader(sr *streamReader) {
delete(sf.pausedReaders, sr)
delete(sf.runningReaders, sr)
}
func (sf *streamFormat) startReader(sr *streamReader) {
if cb, ok := sf.pausedReaders[sr]; ok {
delete(sf.pausedReaders, sr)
sf.runningReaders[sr] = cb
}
}
func (sf *streamFormat) writeUnit(s *Stream, medi *description.Media, u unit.Unit) {
err := sf.proc.ProcessUnit(u)
if err != nil {
sf.DecodeErrors.Increase()
return
}
sf.writeUnitInner(s, medi, u)
}
func (sf *streamFormat) writeRTPPacket(
s *Stream,
medi *description.Media,
pkt *rtp.Packet,
ntp time.Time,
pts int64,
) {
hasNonRTSPReaders := len(sf.pausedReaders) > 0 || len(sf.runningReaders) > 0
u, err := sf.proc.ProcessRTPPacket(pkt, ntp, pts, hasNonRTSPReaders)
if err != nil {
sf.DecodeErrors.Increase()
return
}
sf.writeUnitInner(s, medi, u)
}
func (sf *streamFormat) writeUnitInner(s *Stream, medi *description.Media, u unit.Unit) {
size := unitSize(u)
atomic.AddUint64(s.bytesReceived, size)
if s.rtspStream != nil {
for _, pkt := range u.GetRTPPackets() {
s.rtspStream.WritePacketRTPWithNTP(medi, pkt, u.GetNTP()) //nolint:errcheck
}
}
if s.rtspsStream != nil {
for _, pkt := range u.GetRTPPackets() {
s.rtspsStream.WritePacketRTPWithNTP(medi, pkt, u.GetNTP()) //nolint:errcheck
}
}
for sr, cb := range sf.runningReaders {
ccb := cb
sr.push(func() error {
atomic.AddUint64(s.bytesSent, size)
return ccb(u)
})
}
}