From be54bed373ebacd8fd9494695d1e3c734a52a420 Mon Sep 17 00:00:00 2001
From: aler9 <46489434+aler9@users.noreply.github.com>
Date: Fri, 22 Oct 2021 18:43:46 +0200
Subject: [PATCH] remove useless checks

---
 internal/core/rtsp_session.go | 21 +++++----------------
 1 file changed, 5 insertions(+), 16 deletions(-)

diff --git a/internal/core/rtsp_session.go b/internal/core/rtsp_session.go
index ccb0accd..2e90b3f1 100644
--- a/internal/core/rtsp_session.go
+++ b/internal/core/rtsp_session.go
@@ -167,22 +167,11 @@ func (s *rtspSession) OnAnnounce(c *rtspConn, ctx *gortsplib.ServerHandlerOnAnno
 // OnSetup is called by rtspServer.
 func (s *rtspSession) OnSetup(c *rtspConn, ctx *gortsplib.ServerHandlerOnSetupCtx,
 ) (*base.Response, *gortsplib.ServerStream, error) {
-	switch ctx.Transport {
-	case gortsplib.TransportUDP:
-		if _, ok := s.protocols[conf.Protocol(gortsplib.TransportUDP)]; !ok {
-			return &base.Response{
-				StatusCode: base.StatusUnsupportedTransport,
-			}, nil, nil
-		}
-
-	case gortsplib.TransportUDPMulticast:
-		if _, ok := s.protocols[conf.Protocol(gortsplib.TransportUDPMulticast)]; !ok {
-			return &base.Response{
-				StatusCode: base.StatusUnsupportedTransport,
-			}, nil, nil
-		}
-
-	default: // TCP
+	// in case the client is setupping a stream with UDP or UDP-multicast, and these
+	// transport protocols are disabled, gortsplib already blocks the request.
+	// we have only to handle the case in which the transport protocol is TCP
+	// and it is disabled.
+	if ctx.Transport == gortsplib.TransportTCP {
 		if _, ok := s.protocols[conf.Protocol(gortsplib.TransportTCP)]; !ok {
 			return &base.Response{
 				StatusCode: base.StatusUnsupportedTransport,