From 7a7c9c4a6a8dfe8af986339279c6ec8f69c2e4df Mon Sep 17 00:00:00 2001
From: Alessandro Ros <aler9.dev@gmail.com>
Date: Sun, 8 Jun 2025 13:59:43 +0200
Subject: [PATCH] move checksum generation into Github Actions (#4628)

---
 .github/workflows/nightly_binaries.yml | 4 ++--
 .github/workflows/release.yml          | 4 ++--
 scripts/binaries.mk                    | 8 +-------
 3 files changed, 5 insertions(+), 11 deletions(-)

diff --git a/.github/workflows/nightly_binaries.yml b/.github/workflows/nightly_binaries.yml
index a42b8a11..bcc22c7b 100644
--- a/.github/workflows/nightly_binaries.yml
+++ b/.github/workflows/nightly_binaries.yml
@@ -13,8 +13,8 @@ jobs:
         fetch-depth: 0
 
     - run: make binaries
-      env:
-        CHECKSUM: '1'
+
+    - run: cd binaries; for f in *; do sha256sum $f > $f.sha256sum; done
 
     - uses: actions/upload-artifact@v4
       with:
diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
index 0650f834..68e153c8 100644
--- a/.github/workflows/release.yml
+++ b/.github/workflows/release.yml
@@ -13,8 +13,8 @@ jobs:
     - uses: actions/checkout@v4
 
     - run: make binaries
-      env:
-        CHECKSUM: '1'
+
+    - run: cd binaries; for f in *; do sha256sum $f > $f.sha256sum; done
 
     - uses: actions/upload-artifact@v4
       with:
diff --git a/scripts/binaries.mk b/scripts/binaries.mk
index 995cd62d..7c0f8699 100644
--- a/scripts/binaries.mk
+++ b/scripts/binaries.mk
@@ -1,11 +1,5 @@
 BINARY_NAME = mediamtx
 
-ifeq ($(CHECKSUM),1)
-  define DOCKERFILE_CHECKSUM
-  RUN cd /s/binaries; for f in *; do sha256sum $$f > $$f.sha256sum; done
-  endef
-endif
-
 define DOCKERFILE_BINARIES
 FROM $(BASE_IMAGE) AS build-base
 RUN apk add --no-cache zip make git tar
@@ -62,7 +56,6 @@ COPY --from=build-darwin-arm64 /s/binaries /s/binaries
 COPY --from=build-linux-armv6 /s/binaries /s/binaries
 COPY --from=build-linux-armv7 /s/binaries /s/binaries
 COPY --from=build-linux-arm64 /s/binaries /s/binaries
-$(DOCKERFILE_CHECKSUM)
 endef
 export DOCKERFILE_BINARIES
 
@@ -71,3 +64,4 @@ binaries:
 	-t temp
 	docker run --rm -v "$(shell pwd):/out" \
 	temp sh -c "rm -rf /out/binaries && cp -r /s/binaries /out/"
+	sudo chown -R $(shell id -u):$(shell id -g) binaries