External/mediamtx
1
0
Fork 1
mirror of https://github.com/bluenviron/mediamtx.git synced 2025-12-29 06:22:00 -08:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

enable errcheck (#2201)

Browse source
This commit is contained in:
Alessandro Ros 2023-08-13 16:38:23 +02:00 • committed by GitHub
parent 7001164e2f
commit 659f19f8bb
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
36 changed files with 240 additions and 132 deletions
Download patch file Download diff file Expand all files Collapse all files

3
internal/formatprocessor/generic_test.go
View file

@ -13,7 +13,8 @@ func TestGenericRemovePadding(t *testing.T) {
PayloadTyp: 96,
RTPMa: "private/90000",
}
forma.Init()
err := forma.Init()
require.NoError(t, err)
p, err := New(1472, forma, false, nil)
require.NoError(t, err)

22
internal/formatprocessor/h264_test.go
View file

@ -30,7 +30,8 @@ func TestH264DynamicParams(t *testing.T) {
RTPPackets: []*rtp.Packet{pkts[0]},
},
}
p.Process(data, true)
err = p.Process(data, true)
require.NoError(t, err)
require.Equal(t, [][]byte{
{byte(h264.NALUTypeIDR)},
@ -38,31 +39,37 @@ func TestH264DynamicParams(t *testing.T) {
pkts, err = enc.Encode([][]byte{{7, 4, 5, 6}}, 0) // SPS
require.NoError(t, err)
p.Process(&UnitH264{
err = p.Process(&UnitH264{
BaseUnit: BaseUnit{
RTPPackets: []*rtp.Packet{pkts[0]},
},
}, false)
require.NoError(t, err)
pkts, err = enc.Encode([][]byte{{8, 1}}, 0) // PPS
require.NoError(t, err)
p.Process(&UnitH264{
err = p.Process(&UnitH264{
BaseUnit: BaseUnit{
RTPPackets: []*rtp.Packet{pkts[0]},
},
}, false)
require.NoError(t, err)
require.Equal(t, []byte{7, 4, 5, 6}, forma.SPS)
require.Equal(t, []byte{8, 1}, forma.PPS)
pkts, err = enc.Encode([][]byte{{byte(h264.NALUTypeIDR)}}, 0)
require.NoError(t, err)
data = &UnitH264{
BaseUnit: BaseUnit{
RTPPackets: []*rtp.Packet{pkts[0]},
},
}
p.Process(data, true)
err = p.Process(data, true)
require.NoError(t, err)
require.Equal(t, [][]byte{
{0x07, 4, 5, 6},
@ -127,7 +134,9 @@ func TestH264OversizedPackets(t *testing.T) {
RTPPackets: []*rtp.Packet{pkt},
},
}
p.Process(data, false)
err := p.Process(data, false)
require.NoError(t, err)
out = append(out, data.RTPPackets...)
}
@ -190,7 +199,8 @@ func TestH264EmptyPacket(t *testing.T) {
},
}
p.Process(unit, false)
err = p.Process(unit, false)
require.NoError(t, err)
// if all NALUs have been removed, no RTP packets must be generated.
require.Equal(t, []*rtp.Packet(nil), unit.RTPPackets)

26
internal/formatprocessor/h265_test.go
View file

@ -29,7 +29,8 @@ func TestH265DynamicParams(t *testing.T) {
RTPPackets: []*rtp.Packet{pkts[0]},
},
}
p.Process(data, true)
err = p.Process(data, true)
require.NoError(t, err)
require.Equal(t, [][]byte{
{byte(h265.NALUType_CRA_NUT) << 1, 0},
@ -37,27 +38,33 @@ func TestH265DynamicParams(t *testing.T) {
pkts, err = enc.Encode([][]byte{{byte(h265.NALUType_VPS_NUT) << 1, 1, 2, 3}}, 0)
require.NoError(t, err)
p.Process(&UnitH265{
err = p.Process(&UnitH265{
BaseUnit: BaseUnit{
RTPPackets: []*rtp.Packet{pkts[0]},
},
}, false)
require.NoError(t, err)
pkts, err = enc.Encode([][]byte{{byte(h265.NALUType_SPS_NUT) << 1, 4, 5, 6}}, 0)
require.NoError(t, err)
p.Process(&UnitH265{
err = p.Process(&UnitH265{
BaseUnit: BaseUnit{
RTPPackets: []*rtp.Packet{pkts[0]},
},
}, false)
require.NoError(t, err)
pkts, err = enc.Encode([][]byte{{byte(h265.NALUType_PPS_NUT) << 1, 7, 8, 9}}, 0)
require.NoError(t, err)
p.Process(&UnitH265{
err = p.Process(&UnitH265{
BaseUnit: BaseUnit{
RTPPackets: []*rtp.Packet{pkts[0]},
},
}, false)
require.NoError(t, err)
require.Equal(t, []byte{byte(h265.NALUType_VPS_NUT) << 1, 1, 2, 3}, forma.VPS)
require.Equal(t, []byte{byte(h265.NALUType_SPS_NUT) << 1, 4, 5, 6}, forma.SPS)
@ -65,12 +72,14 @@ func TestH265DynamicParams(t *testing.T) {
pkts, err = enc.Encode([][]byte{{byte(h265.NALUType_CRA_NUT) << 1, 0}}, 0)
require.NoError(t, err)
data = &UnitH265{
BaseUnit: BaseUnit{
RTPPackets: []*rtp.Packet{pkts[0]},
},
}
p.Process(data, true)
err = p.Process(data, true)
require.NoError(t, err)
require.Equal(t, [][]byte{
{byte(h265.NALUType_VPS_NUT) << 1, 1, 2, 3},
@ -124,7 +133,9 @@ func TestH265OversizedPackets(t *testing.T) {
RTPPackets: []*rtp.Packet{pkt},
},
}
p.Process(data, false)
err = p.Process(data, false)
require.NoError(t, err)
out = append(out, data.RTPPackets...)
}
@ -187,7 +198,8 @@ func TestH265EmptyPacket(t *testing.T) {
},
}
p.Process(unit, false)
err = p.Process(unit, false)
require.NoError(t, err)
// if all NALUs have been removed, no RTP packets must be generated.
require.Equal(t, []*rtp.Packet(nil), unit.RTPPackets)