From 1a53e40bdc5b5e55cd29401bb229ca8284c0a104 Mon Sep 17 00:00:00 2001 From: Alessandro Ros Date: Sun, 25 Jan 2026 13:51:49 +0100 Subject: [PATCH] switch to reflect.Pointer (#5377) --- internal/api/api.go | 2 +- internal/conf/conf.go | 2 +- internal/metrics/metrics.go | 2 +- internal/servers/hls/server.go | 2 +- internal/servers/rtmp/server.go | 2 +- internal/servers/rtsp/server.go | 2 +- internal/servers/srt/server.go | 2 +- internal/servers/webrtc/server.go | 2 +- 8 files changed, 8 insertions(+), 8 deletions(-) diff --git a/internal/api/api.go b/internal/api/api.go index 1a28c95c..4dae0691 100644 --- a/internal/api/api.go +++ b/internal/api/api.go @@ -20,7 +20,7 @@ import ( ) func interfaceIsEmpty(i any) bool { - return reflect.ValueOf(i).Kind() != reflect.Ptr || reflect.ValueOf(i).IsNil() + return reflect.ValueOf(i).Kind() != reflect.Pointer || reflect.ValueOf(i).IsNil() } func sortedKeys(paths map[string]*conf.Path) []string { diff --git a/internal/conf/conf.go b/internal/conf/conf.go index 6e09e214..1a54e54a 100644 --- a/internal/conf/conf.go +++ b/internal/conf/conf.go @@ -63,7 +63,7 @@ func copyStructFields(dest any, source any) { if fnew.Kind() == reflect.Pointer { if !fnew.IsNil() { - if f.Kind() == reflect.Ptr { + if f.Kind() == reflect.Pointer { f.Set(fnew) } else { f.Set(fnew.Elem()) diff --git a/internal/metrics/metrics.go b/internal/metrics/metrics.go index d05a07f9..cc1387cb 100644 --- a/internal/metrics/metrics.go +++ b/internal/metrics/metrics.go @@ -21,7 +21,7 @@ import ( ) func interfaceIsEmpty(i any) bool { - return reflect.ValueOf(i).Kind() != reflect.Ptr || reflect.ValueOf(i).IsNil() + return reflect.ValueOf(i).Kind() != reflect.Pointer || reflect.ValueOf(i).IsNil() } func sortedKeys(paths map[string]string) []string { diff --git a/internal/servers/hls/server.go b/internal/servers/hls/server.go index d4edffbe..272d45c7 100644 --- a/internal/servers/hls/server.go +++ b/internal/servers/hls/server.go @@ -19,7 +19,7 @@ import ( var ErrMuxerNotFound = errors.New("muxer not found") func interfaceIsEmpty(i any) bool { - return reflect.ValueOf(i).Kind() != reflect.Ptr || reflect.ValueOf(i).IsNil() + return reflect.ValueOf(i).Kind() != reflect.Pointer || reflect.ValueOf(i).IsNil() } type serverGetMuxerRes struct { diff --git a/internal/servers/rtmp/server.go b/internal/servers/rtmp/server.go index a545c93b..09088661 100644 --- a/internal/servers/rtmp/server.go +++ b/internal/servers/rtmp/server.go @@ -26,7 +26,7 @@ import ( var ErrConnNotFound = errors.New("connection not found") func interfaceIsEmpty(i any) bool { - return reflect.ValueOf(i).Kind() != reflect.Ptr || reflect.ValueOf(i).IsNil() + return reflect.ValueOf(i).Kind() != reflect.Pointer || reflect.ValueOf(i).IsNil() } type serverAPIConnsListRes struct { diff --git a/internal/servers/rtsp/server.go b/internal/servers/rtsp/server.go index d21eb4d1..60b383b3 100644 --- a/internal/servers/rtsp/server.go +++ b/internal/servers/rtsp/server.go @@ -33,7 +33,7 @@ var ErrConnNotFound = errors.New("connection not found") var ErrSessionNotFound = errors.New("session not found") func interfaceIsEmpty(i any) bool { - return reflect.ValueOf(i).Kind() != reflect.Ptr || reflect.ValueOf(i).IsNil() + return reflect.ValueOf(i).Kind() != reflect.Pointer || reflect.ValueOf(i).IsNil() } func printAddresses(srv *gortsplib.Server) string { diff --git a/internal/servers/srt/server.go b/internal/servers/srt/server.go index 583c15ee..2180b718 100644 --- a/internal/servers/srt/server.go +++ b/internal/servers/srt/server.go @@ -24,7 +24,7 @@ import ( var ErrConnNotFound = errors.New("connection not found") func interfaceIsEmpty(i any) bool { - return reflect.ValueOf(i).Kind() != reflect.Ptr || reflect.ValueOf(i).IsNil() + return reflect.ValueOf(i).Kind() != reflect.Pointer || reflect.ValueOf(i).IsNil() } func srtMaxPayloadSize(u int) int { diff --git a/internal/servers/webrtc/server.go b/internal/servers/webrtc/server.go index 3711ac1e..6cd812a6 100644 --- a/internal/servers/webrtc/server.go +++ b/internal/servers/webrtc/server.go @@ -40,7 +40,7 @@ const ( var ErrSessionNotFound = errors.New("session not found") func interfaceIsEmpty(i any) bool { - return reflect.ValueOf(i).Kind() != reflect.Ptr || reflect.ValueOf(i).IsNil() + return reflect.ValueOf(i).Kind() != reflect.Pointer || reflect.ValueOf(i).IsNil() } type nilWriter struct{}