External/mediamtx
1
0
Fork 1
mirror of https://github.com/bluenviron/mediamtx.git synced 2025-12-20 02:00:05 -08:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

api: return 500 instead of 404 in case of non-existing items (#2582)

Browse source 
This is needed to differentiate between calls to non-existent andpoints
and calls to valid endpoints, but with an ID pointing to a non-existing
item, and to return JSON in the latter case.
This commit is contained in:
Alessandro Ros 2023-10-27 20:23:46 +02:00 • committed by GitHub
parent 6af27fdcf8
commit 07ff79f553
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
9 changed files with 69 additions and 124 deletions
Download patch file Download diff file Expand all files Collapse all files

10
internal/core/api_test.go
View file

@ -398,7 +398,7 @@ func TestAPIConfigPathsDelete(t *testing.T) {
res, err := hc.Do(req)
require.NoError(t, err)
defer res.Body.Close()
require.Equal(t, http.StatusNotFound, res.StatusCode)
require.Equal(t, http.StatusInternalServerError, res.StatusCode)
}()
}
@ -650,7 +650,7 @@ func TestAPIPathsGet(t *testing.T) {
res, err := hc.Get("http://localhost:9997/v3/paths/get/" + pathName)
require.NoError(t, err)
defer res.Body.Close()
require.Equal(t, 404, res.StatusCode)
require.Equal(t, http.StatusInternalServerError, res.StatusCode)
}
})
}
@ -1331,7 +1331,7 @@ func TestAPIProtocolGetNotFound(t *testing.T) {
res, err := hc.Do(req)
require.NoError(t, err)
defer res.Body.Close()
require.Equal(t, http.StatusNotFound, res.StatusCode)
require.Equal(t, http.StatusInternalServerError, res.StatusCode)
}()
})
}
@ -1537,13 +1537,13 @@ func TestAPIProtocolKickNotFound(t *testing.T) {
}
func() {
req, err := http.NewRequest(http.MethodGet, "http://localhost:9997/v3/"+pa+"/kick/"+uuid.New().String(), nil)
req, err := http.NewRequest(http.MethodPost, "http://localhost:9997/v3/"+pa+"/kick/"+uuid.New().String(), nil)
require.NoError(t, err)
res, err := hc.Do(req)
require.NoError(t, err)
defer res.Body.Close()
require.Equal(t, http.StatusNotFound, res.StatusCode)
require.Equal(t, http.StatusInternalServerError, res.StatusCode)
}()
})
}