* [LTR] Implement Stone of Erech
Grouped together two other recent cards for that exact same replacement effect.
* refactor some more
This does extend the ReplacementEffect "If ... would die, exile it instead", using a `PermanentFilter`. [[Void Maw]] and [[Lorcan, Warlock Collector]] have thus be refactored to use that instead of a custom replacement effect.
Added a static filter `StaticFilters.FILTER_ANOTHER_CREATURE` for Void Maw that is filtering "another creature".
Found and refactored cards that were declaring that exact filter locally
* [[Flame-Kin War Scout]]
* [[Herd Gnarr]]
* [[Mogg Bombers]]
* [[Timid Drake]]
* fix void maw
* reverse changes on VoidMaw
Void Maw was a linked ability, so not exactly the same replacement effect that was refactored.
* fix Unsettled Mariner + Field of Ruin
There was something weird with zcc on TargetOfOpponentsSpellOrAbilityTriggeredAbility
setting the target to the stack object for its triggered effect.
I do not entirely comprehend how FixedTarget works, in particular regarding zcc of stack objects.
However all configurations of the trigger seem to work with the uninitialized FixedTarget constructor,
instead of the one initialized with a game's zcc.
* slight refactor of TargetOfOpponentsSpellOrAbilityTriggeredAbility
* First try at Squad Mechanic
* Fully functional now, removed cards from unfinished list in 40k
* Improved implementation, removing the generic conditional
and replacing it with a separated ETB trigger and effect.
* Add tests from Susucre (using Strionic Resonator for now, two others currently failing)
* Update comments on tests
Closes#9774
------
Co-authored by: Susucre <34709007+susucre@users.noreply.github.com>
- Fix superfluous null check in Lithoform Engine
- Remove hardcoding of controlled abilities in TargetTriggeredAbility (used only in Strionic Resonator)
- EnchantmentSourcePredicate analogous to ArtifactSourcePredicate
