theelk801
78c8686876
remove unnecessary filter constructors from TargetLandPermanent
2025-05-27 22:02:14 -04:00
xenohedron
b02898093f
refactor: SimpleStaticAbility default zone (cards Q R)
2024-11-16 23:04:53 -05:00
xenohedron
5b0eba7068
refactor: end step triggered abilities ( #13047 )
...
* simplify BeginningOfEndStepTriggeredAbility
* more simplifications
* move to common class
* find and replace to common class
* simplify again
* align parameter order
* package reorg
* simplify BeginningOfCombatTriggeredAbility constructors
* simplify BeginningOfFirstMainTriggeredAbility constructors
* text fixes
* update docs
2024-10-28 01:49:11 -04:00
xenohedron
587a68a837
refactor: simplify BeginningOfUpkeepTriggeredAbility ( #13046 )
...
* remove superfluous zone.battlefield
* remove redundant TargetController.YOU
* remove unneeded param
* simpler constructor with default optional false
* move to inheritance structure
remove setTargetPointer
* adjust
* align trigger phrase text
* add comments, fix param
* fix params and text
* fix params to fix text
* simplify
* package reorg
2024-10-28 00:15:59 -04:00
xenohedron
e24b9df58e
cleanup Quicksilver Fountain
2024-06-02 21:28:14 -04:00
Susucre
20b7a115da
prevent direct access of Player->counters ; some cleanup on counter removal effects ; implement [MH3] Izzet Generatorium ( #12314 )
2024-05-29 22:34:54 +02:00
xenohedron
44893028f5
refactor: Constructor access modifier cleanup ( #11644 )
...
* ContinuousRuleModifyingEffectImpl
* OneShotEffect
* ContinuousEffectImpl
* fix CRLF
* *EffectImpl
* *Effect
* DoIfCostPaid
* cleanup token copy constructors -> private
* fix build error from misspelled class name
2024-01-13 00:53:22 -05:00
Susucre
430a3bf7f9
refactor: clean all copy constructors in cards starting P-Q-R ( #11095 )
2023-09-02 03:10:45 +04:00
Alex W. Jackson
dd8d86ba95
Fix Navigator's Compass not working while casting spells
2022-02-20 13:24:57 -05:00
Evan Kranzler
572104b8fc
Reworking card types in preparation for implementing Grist, the Hunger Tide ( #7899 )
...
Co-authored-by: Oleg Agafonov <jaydi85@gmail.com>
2021-07-09 07:28:43 +04:00
Evan Kranzler
56603ffcd2
refactored card copy methods to be private
2021-02-02 17:07:37 -05:00
Evan Kranzler
a535cb5adc
Refactoring methods which add counters to track which player adds the counters (ready for review) ( #7448 )
...
* added parameter for player adding counters to players
* added parameter for player adding counters to cards/permanents
* updated methods to use new parameter
* fixed a few initial errors
* refactored instances of cards that add counters by a player other than the controller
* fixed some instances of incorrect arguments
* refactored abilities that trigger off of a particular player adding counters
* a few more cards that were missed
* [KHM] Implemented Vorinclex, Monstrous Raider
* added test for Vorinclex, Monstrous Raider
* fixed a test failure
2021-01-26 19:06:13 -05:00
Oleg Agafonov
db239a1055
Refactor: replaced sourceId by source and introduced source param in some methods;
2020-12-12 20:23:19 +04:00
jeffwadsworth
0385d9a653
- Removed some test code
2020-07-28 18:01:12 -05:00
jeffwadsworth
92580e480b
- More fixes related to #6855
2020-07-28 17:58:43 -05:00
jeffwadsworth
d6c2f031d0
- Fixed #6236
2020-02-06 17:47:08 -06:00
Evan Kranzler
9c3b923b3f
refactored ControllerPredicate
2020-01-06 20:04:56 -05:00
Evan Kranzler
86906ec25f
refactored all instances of SubtypePredicate
2020-01-06 16:48:00 -05:00
ssouders412
2d3247d732
Updated pronouns to reflect current rules and oracle text
...
Replaced all instances of "her or she", "him or her", and "his or her", with "they", "them", and "their", or sometimes "that player". Updated verbs where appropriate.
2019-12-06 14:29:36 -05:00
Evan Kranzler
af32dfefb4
begin TargetAdjuster refactor
2018-09-22 16:29:15 -04:00
GrayedFox
3953f3dbdd
remove all MIT copyright notices from files
2018-06-02 17:59:49 +02:00
Evan Kranzler
a6e51e592b
Changed all card classes to final
...
I was tired of the "overridable method call in constructor" warning and card classes should be final anyway
2018-05-21 10:53:44 -04:00
igoudt
00f91391e9
Homarid Drake, reprints, and rewriting his or her to their
2018-03-22 16:52:26 +01:00
Evan Kranzler
0ddc791f08
fixed Quicksilver Fountain issue
2017-08-30 16:46:11 -04:00
Evan Kranzler
358d496803
fixed bug #3279
2017-08-24 18:46:48 -04:00
igoudt
8d52e995e8
change BEcomesBasicLandTargetEffect to use SubType
2017-08-07 21:58:59 +02:00
LevelX2
b9dff66fcb
* Kormus Bell - Fixed a bug with order land type changing effects are applied ( fixes #3470 ).
2017-07-28 16:56:31 +02:00
LevelX2
cd6c7623ed
* Added missing imports, imports reorg.
2017-07-23 16:29:29 +02:00
igoudt
19db21c672
subtypes part 2
2017-05-20 22:41:25 +02:00
igoudt
01813cce0c
fix for quicksilver fountain, as it let you target all lands in play instead of your own
2017-04-30 17:45:23 +02:00
Achilles
8bcb2d1d2d
- Added Quicksilver Fountain
2017-03-23 15:13:13 -05:00
