Commit graph

12328 commits

Author SHA1 Message Date
Oleg Agafonov
52ebba4cd1 refactor: removed outdated code 2024-11-30 04:23:23 +04:00
Oleg Agafonov
fdbc5d6409 docs: added additional notes for 616, related to #13062 2024-11-30 04:23:21 +04:00
Oleg Agafonov
0689c56597 refactor: fixed dies events support in single cards (part 4); 2024-11-30 04:23:21 +04:00
Oleg Agafonov
dc9f349828 refactor: fixed dies events support in single cards (part 3); 2024-11-30 04:23:21 +04:00
Oleg Agafonov
c3343110f3 refactor: fixed dies events support in single cards (part 2); 2024-11-30 04:23:21 +04:00
Oleg Agafonov
66b338c6fc dies triggers improves:
* tests: added additional tests and verify/runtime checks for wrong die trigger settings;
* refactor: removed some usage of short LKI ;
* fixed dies events support in "or trigger" and "conditional trigger" (use cases like sacrifice cost);
* fixed dies events support in shared triggered abilities (use cases like sacrifice cost);
2024-11-30 04:23:21 +04:00
xenohedron
d6cf207a8b
Introduce new batch event for life lost for a specific player (#13071)
* Introduce new batch event for life lost for a specific player

closes #12202, fix #10805

* implement [DSC] Valgavoth, Harrower of Souls

* text fixes
2024-11-19 23:41:34 -05:00
xenohedron
95e986dee7 add reminder text for Flanking ability 2024-11-19 23:22:35 -05:00
xenohedron
d06d594934
rework batch events (#13066)
* add new framework for batch triggers

apply for tapped, untapped, sacrificed, milled

simplify Ob Nixilis, Captive Kingpin

* add a verify check

* fix mistakes

* add simple tests

* another test

* zone change - enters battlefield

* zone change: not battlefield

* zone change - leaves battlefield

* fix Kaya Spirit's Justice

* rename OneOrMoreCombatDamagePlayerTriggeredAbility

* refactor OneOrMoreDamagePlayerTriggeredAbility

* new YoureDealtDamageTriggeredAbility

* new OpponentDealtNoncombatDamageTriggeredAbility

* rework Risona, Asari Commander

* simplify War Elemental

* Add damage batch by source

rework some delayed triggered abilities

* fix Mindblade Render

* rework Initiative and a few others

* [temp] initiative test

* refactor: common style for DealsDamageSourceTriggeredAbility

* refactor cards to use common DealsDamageSourceTriggeredAbility

* update damage players batch triggers

* fix mistake in initiative

* new DealtDamageAnyTriggeredAbility

* new DealtCombatDamageToSourceTriggeredAbility

* update dealt damage to permanent batch triggered abilities

* refactor Hot Soup and param in DealtDamageAttachedTriggeredAbility

* a few more permanent batch triggered abilities

* fix mistake

* update some more damage batch triggers

* add test for Phyrexian Negator

* update Felix Five-Boots and enable test

update Wayta, Trainer Prodigy to align

* update damage batch by source triggers

* undo mistaken change

* fix verify

* cleanup unused methods

* Revert "[temp] initiative test"

This reverts commit 11ed19295f.

* Revert "add a verify check"

This reverts commit e7de47a656.

* fixes from checking text discrepancies

* fix Shriekwood Devourer

* merge fix

---------

Co-authored-by: Susucre <34709007+Susucre@users.noreply.github.com>
2024-11-19 21:23:08 -05:00
theelk801
10f03d0d12 [DSC] Implement Formless Genesis 2024-11-18 19:23:45 -05:00
xenohedron
0e1fa94a11 refactor: SimpleActivatedAbility default zone (cards X Y Z, emblems, tokens) 2024-11-16 23:04:53 -05:00
xenohedron
139ca1ebe1 refactor: SimpleStaticAbility default zone (second line) 2024-11-16 23:04:53 -05:00
xenohedron
ca6d0302b7 refactor: SimpleStaticAbility default zone (separate line) 2024-11-16 23:04:53 -05:00
xenohedron
39512d75ac refactor: SimpleStaticAbility default zone (before newline) 2024-11-16 23:04:53 -05:00
xenohedron
994c97e86a refactor: SimpleStaticAbility default zone (tokens, emblems, etc.) 2024-11-16 23:04:53 -05:00
xenohedron
178b7e0343 text fixes 2024-11-16 22:02:04 -05:00
PurpleCrowbar
013cf2721f Add FDN token images 2024-11-16 23:52:48 +00:00
theelk801
a609d044ec [J25] Implement Slinza, the Spiked Stampede 2024-11-14 11:27:55 -05:00
theelk801
405a6d7c2a [J25] Implement Gornog, the Red Reaper 2024-11-13 17:15:45 -05:00
theelk801
c360d007e6 [J25] Implement Delightful Discovery 2024-11-13 11:07:13 -05:00
theelk801
659fadba96 [J25] Implement Ozox, the Clattering King 2024-11-12 12:15:25 -05:00
theelk801
c168cb06c0 [J25] Implement Plagon, Lord of the Beach 2024-11-12 10:40:40 -05:00
theelk801
93d412406d [J25] Implement Hurska Sweet-Tooth 2024-11-12 10:30:39 -05:00
theelk801
43cdf845d5 [J25] Implement Fumulus, the Infestation 2024-11-12 10:26:13 -05:00
theelk801
afe97b1f8a [J25] Implement Generous Pup 2024-11-11 12:03:59 -05:00
theelk801
d7ae7b0e4d [J25] Implement Nazar, the Velvet Fang 2024-11-11 11:58:42 -05:00
ciaccona007
6c2e7a3fd3 [PIP] Implement Overencumbered 2024-11-05 17:58:19 -05:00
Steven Knipe
f15b3cdb30 [FDN] Uncharted Voyage, add option for "their choice" wording 2024-11-05 01:10:36 -08:00
theelk801
8ecb0b96ac [FDN] fix counter type for Ravenous Amulet 2024-11-04 20:45:21 -05:00
theelk801
28cbb41c14 [FDN] Implement Ravenous Amulet 2024-11-04 20:35:56 -05:00
ciaccona007
31064f2604 [FDN] Implement Nine-Lives Familiar 2024-11-04 10:23:48 -05:00
ciaccona007
0563802da5 [FDN] Implement Loot, Exuberant Explorer 2024-11-04 09:29:10 -05:00
ciaccona007
a387c5ed67 [FDN] Implement Kiora, the Rising Tide 2024-11-04 09:01:24 -05:00
xenohedron
e3d654dcb0 more text fixes 2024-11-03 22:06:51 -05:00
xenohedron
a98ff3867c various text fixes 2024-11-03 21:49:03 -05:00
ciaccona007
a5d2338c5a [FDN] Implement Kaito, Cunning Infiltrator 2024-11-03 18:48:48 -05:00
ciaccona007
13d33d7de1 [FDN] Implement Fishing Pole 2024-11-03 16:40:20 -05:00
ciaccona007
05eb4a6189 [FDN] Implement Elenda, Saint of Dusk 2024-11-03 09:16:23 -05:00
ciaccona007
931b81a4b9 [FDN] Implement Drake Hatcher 2024-11-02 22:57:09 -04:00
theelk801
53844daddf [FDN] Implement Hare Apparent 2024-11-02 16:33:17 -04:00
ciaccona007
6a324d97ca [FDN] Implement Cat Collector 2024-11-02 15:49:25 -04:00
theelk801
ca91c976c4 [FDN] Implement Guarded Heir 2024-10-31 12:26:02 -04:00
theelk801
9226e5239f [FDN] Implement Strongbox Raider 2024-10-31 11:41:36 -04:00
theelk801
0e4730ca20 [J25] Implement Cynette, Jelly Drover 2024-10-30 16:05:03 -04:00
theelk801
b0055fd2ea [FDN] Implement Mischievous Mystic 2024-10-29 17:54:03 -04:00
theelk801
482fbf0d0c [FDN] Implement Herald of Eternal Dawn 2024-10-28 15:30:52 -04:00
xenohedron
5b0eba7068
refactor: end step triggered abilities (#13047)
* simplify BeginningOfEndStepTriggeredAbility

* more simplifications

* move to common class

* find and replace to common class

* simplify again

* align parameter order

* package reorg

* simplify BeginningOfCombatTriggeredAbility constructors

* simplify BeginningOfFirstMainTriggeredAbility constructors

* text fixes

* update docs
2024-10-28 01:49:11 -04:00
xenohedron
587a68a837
refactor: simplify BeginningOfUpkeepTriggeredAbility (#13046)
* remove superfluous zone.battlefield

* remove redundant TargetController.YOU

* remove unneeded param

* simpler constructor with default optional false

* move to inheritance structure

remove setTargetPointer

* adjust

* align trigger phrase text

* add comments, fix param

* fix params and text

* fix params to fix text

* simplify

* package reorg
2024-10-28 00:15:59 -04:00
xenohedron
eee0fee79e
refactor: common logic for "at..." triggered abilities (#13045)
* add new common framework for at step triggered abilities

* move postcombat main and second main triggers to it

* update draw step triggers

* refactor BeginningOfCombatTriggeredAbility

* refactor BeginningOfFirstMainTriggeredAbility

* move Pronoun to constants package

* cleanup some cards to use simpler constructors

* package reorganization
2024-10-27 21:03:40 -04:00
xenohedron
aa7a610db2
refactor: clean up triggered abilities from graveyard (#13044)
* some improvements to counter removing triggers

* fix Zone.GRAVEYARD text/conditions for beginning of upkeep triggers

* remaining refactors

* add condition text

* text corrections

* remove remaining generateZoneString

* remove superfluous hardcoded rules text param
2024-10-27 15:23:54 -04:00