theelk801
29acaa423b
add hasName method
2025-06-23 16:39:45 -04:00
theelk801
fda43021a4
add helper method for creating filters which only select from a collection of permanents
2025-06-23 09:38:05 -04:00
theelk801
747e4e5569
rework CreateTokenAttachSourceEffect to properly handle multiple tokens being created
2025-06-23 09:38:05 -04:00
ReSech
a4cb983401
images: added missing tokens to UND, UGL and WHO ( #13779 )
2025-06-22 11:51:12 +04:00
xenohedron
c07837f743
a couple text fixes
2025-06-21 19:18:31 -04:00
xenohedron
78e1ef6271
style fixes
...
filters should be declared `private static final`
2025-06-21 18:45:24 -04:00
ReSech
fbd57cb58f
images: added missing tokens for UNF, TDC & DSK ( #13775 )
2025-06-21 13:18:20 +04:00
ReSech
de383f6908
images: added new tokens for FIC/FIN, copy, monarch and other ( #13760 )
2025-06-21 08:19:04 +04:00
theelk801
8ff2a59981
[EOE] Implement Sami, Ship's Engineer
2025-06-20 22:27:00 -04:00
ssk97
5db4beac6c
Adding targets (Part 3/3) ( #13769 )
...
Adds target and/or target adjuster to cards whose abilities have the word "target", cards S-Z.
Add `spellCast` value to `CastSpellPaidBySourceTriggeredAbility`.
2025-06-20 18:58:13 -07:00
theelk801
b24a20fec4
refactor: create GainLifeAllEffect
2025-06-20 15:50:06 -04:00
theelk801
dfd09d9a78
[PIP] Implement Nuka-Nuke Launcher
2025-06-20 14:04:36 -04:00
theelk801
ebe9284428
[CLU] Implement Dimir Strandcatcher
2025-06-20 10:32:18 -04:00
theelk801
3827d8285c
[EOE] Implement Tezzeret, Cruel Captain
2025-06-20 09:25:52 -04:00
theelk801
4ce5d2d431
fix test failures
2025-06-20 08:52:41 -04:00
theelk801
9744819551
finish removing all filter constructors from TargetCreaturePermanent
2025-06-20 08:29:54 -04:00
theelk801
3e65021150
partially refactor TargetCreaturePermanent constructors
2025-06-20 08:29:53 -04:00
theelk801
80500b5b94
some more target filter refactors
2025-06-20 08:29:53 -04:00
theelk801
b19d8fea76
remove filter constructors from TargetControlledCreaturePermanent
2025-06-19 11:10:53 -04:00
theelk801
96b39c1210
replace some instances of EntersBattlefieldControlledTriggeredAbility with EntersBattlefieldAllTriggeredAbility
2025-06-19 11:10:14 -04:00
ssk97
219cc53cf4
Adding targets (Part 2/3) ( #13765 )
...
Adds target and/or target adjuster to cards whose abilities have the word "target", cards H-R.
fix EffectKeyValue text, NestOfScarabs
Add X value to effects for CycleTriggeredAbility, use with ValorsFlagship and SharkTyphoon, add test
2025-06-18 21:14:16 -07:00
theelk801
7be454fb92
some text fixes
2025-06-18 16:40:18 -04:00
theelk801
d2b507650b
replace all instances of ConditionalActivatedAbility with ActivateIfConditionActivatedAbility
2025-06-18 16:06:13 -04:00
theelk801
f89efd226a
add ConditionalActivatedAbility code to ActivateIfConditionActivatedAbility
2025-06-18 15:43:31 -04:00
theelk801
fe1b01114f
simplify ConditionalActivatedAbility constructors more
2025-06-18 15:42:18 -04:00
theelk801
bbbc2e5baf
use static upkeep method for IsStepCondition
2025-06-18 13:52:49 -04:00
theelk801
fd371c8932
remove timing argument from ActivateIfConditionActivatedAbility
2025-06-18 13:52:48 -04:00
theelk801
72551143a3
rework ConditionalActivatedAbility text constructor
2025-06-18 13:52:48 -04:00
Oleg Agafonov
ffe902d25e
AI: purged whole targeting code and replaced with simple and shared logic (part of #13638 ) ( #13766 )
...
- refactor: removed outdated/unused code from AI, battlefield score, targeting, etc;
- ai: removed all targeting and filters related logic from ComputerPlayer;
- ai: improved targeting with shared and simple logic due effect's outcome and possible targets priority;
- ai: improved get amount selection (now AI will not choose big and useless values);
- ai: improved spell selection on free cast (now AI will try to cast spells with valid targets only);
- tests: improved result table with first bad dialog info for fast access (part of #13638 );
2025-06-18 21:03:58 +04:00
ssk97
1fe0d92c86
Attacks player with creatures triggered ability, Implement [BLC] Echoing Assault ( #13764 )
...
Create AttacksPlayerWithCreaturesTriggeredAbility, and tests for that ability via Soaring Lightbringer.
Implement Echoing Assault.
2025-06-18 05:54:36 -07:00
ssk97
9ce5dd212a
Adding targets (Part 1/3) ( #13680 )
...
Adds target and/or target adjuster to cards whose abilities have the word "target", cards A-G.
Creates SourceDealsNoncombatDamageToOpponentTriggeredAbility and DefineByTriggerTargetAdjuster
2025-06-17 22:35:49 -07:00
theelk801
6d3bd7a19f
refactor: remove OnEventTriggeredAbility
2025-06-15 15:28:08 -04:00
Oleg Agafonov
d893d52190
tests: improved testable dialogs (added source code ref in result table for better IDE navigation, part of #13643 , #13638 );
2025-06-15 14:08:43 +04:00
xenohedron
7a44ee2a97
fix #12974 (zcc check in ReturnToBattlefieldUnderOwnerControlAttachedEffect)
...
add test
2025-06-14 21:20:17 -04:00
theelk801
d43e96eaf2
some more text fixes
2025-06-14 11:38:00 -04:00
theelk801
96cc1e40ee
fix text for enchantments that turn into creatures permanently
2025-06-14 10:16:01 -04:00
Oleg Agafonov
6ad2cdaa78
AI: improved stability:
...
- fixed game errors with source related filters (related to #13713 );
- fixed game freeze in hand's cards selection (related to #13290 );
- fixed game freeze in target amount selection with X=0 (related to #13290 );
2025-06-14 16:03:44 +04:00
Oleg Agafonov
e8342e1f11
refactor: improved usage of getSourceObjectZoneChangeCounter, added docs (part of #13737 )
2025-06-14 15:31:24 +04:00
xenohedron
492c7c9db8
a bunch of unrelated text fixes
2025-06-14 01:53:56 -04:00
xenohedron
519a9e0c49
small text generation improvement
2025-06-14 01:00:42 -04:00
xenohedron
1b8602bd15
improve text generation for intervening if triggers
2025-06-14 00:46:07 -04:00
xenohedron
24f030fa71
fix #13523 (trigger on becomes the target of recast spell) ( #13740 )
...
move findTargetingStackObject from CardUtil to Game, so saved data can be cleared with short living lki
add test cases
2025-06-14 00:09:40 -04:00
Oleg Agafonov
eec4f0ac7e
merge fix
2025-06-13 23:52:59 +04:00
Oleg Agafonov
62eb116124
merge fix
2025-06-13 23:43:55 +04:00
Oleg Agafonov
849aea5946
tests: added fuzzy testing (disabled by default, added random phased out permanents, part of #13748 );
2025-06-13 23:09:05 +04:00
theelk801
58b5bb76f9
various text fixes
2025-06-13 13:44:33 -04:00
theelk801
90d51013ad
Delete ConditionalInterveningIfTriggeredAbility.java
2025-06-12 19:59:15 -04:00
theelk801
dbd07b9031
and when the elk saw the breadth of his domain, he wept, for there was no more ConditionalInterveningIfTriggeredAbility to refactor
2025-06-12 19:58:54 -04:00
theelk801
79a2f80563
listening to Pet Sounds on repeat while I refactor ConditionalInterveningIfTriggeredAbility
2025-06-12 19:56:43 -04:00
theelk801
cdcda710c8
people keep asking me if I'm refactoring ConditionalInterveningIfTriggeredAbility, and I haven't really had an answer. but now yeah, I'm thinking I'm refactoring ConditionalInterveningIfTriggeredAbility
2025-06-12 19:56:43 -04:00
