External/mage
1
0
Fork 1
mirror of https://github.com/magefree/mage.git synced 2026-01-24 12:19:59 -08:00
Code Issues Projects Releases Packages Wiki Activity Actions

[minor] Address PR comments in ECL cards (#14172)

Browse source 
* Cleanup redundant ability assignment

* Remove redundant Duration.EndOfTurn arguments. nb not cleaning up the other instances of this in the codebase quite yet as this would be a massive change

* Don't reimplement existing StaticFilter as custom filter
This commit is contained in:
Muz 2026-01-06 09:35:19 -06:00 • committed by GitHub
parent 7cd1c87dbd
commit f8e80b3534
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 5 additions and 14 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Mage.Sets/src/mage/cards/l/LysAlanaInformant.java
View file

@ -3,7 +3,6 @@ package mage.cards.l;
import java.util.UUID;
import mage.MageInt;
import mage.abilities.Ability;
import mage.abilities.common.EntersBattlefieldOrDiesSourceTriggeredAbility;
import mage.abilities.effects.keyword.SurveilEffect;
import mage.cards.CardImpl;
@ -26,8 +25,7 @@ public final class LysAlanaInformant extends CardImpl {
this.toughness = new MageInt(1);
// When this creature enters or dies, surveil 1.
Ability ability = new EntersBattlefieldOrDiesSourceTriggeredAbility(new SurveilEffect(1), false);
this.addAbility(ability);
this.addAbility(new EntersBattlefieldOrDiesSourceTriggeredAbility(new SurveilEffect(1), false));
}
private LysAlanaInformant(final LysAlanaInformant card) {

5
Mage.Sets/src/mage/cards/t/ThoughtweftLieutenant.java
View file

@ -13,7 +13,6 @@ import mage.target.common.TargetControlledCreaturePermanent;
import mage.cards.CardImpl;
import mage.cards.CardSetInfo;
import mage.constants.CardType;
import mage.constants.Duration;
/**
*
@ -33,9 +32,9 @@ public final class ThoughtweftLieutenant extends CardImpl {
// Whenever this creature or another Kithkin you control enters, target creature you control gets +1+1 and gains trample until end of turn.
Ability ability = new EntersBattlefieldThisOrAnotherTriggeredAbility(
new BoostTargetEffect(1, 1, Duration.EndOfTurn).setText("target creature you control gets +1/+1"), filter, false, true
new BoostTargetEffect(1, 1).setText("target creature you control gets +1/+1"), filter, false, true
);
ability.addEffect(new GainAbilityTargetEffect(TrampleAbility.getInstance(), Duration.EndOfTurn)
ability.addEffect(new GainAbilityTargetEffect(TrampleAbility.getInstance())
.setText("and gains trample until end of turn"));
ability.addTarget(new TargetControlledCreaturePermanent());
}

10
Mage.Sets/src/mage/cards/v/VirulentEmissary.java
View file

@ -10,8 +10,7 @@ import mage.cards.CardImpl;
import mage.cards.CardSetInfo;
import mage.constants.CardType;
import mage.constants.SubType;
import mage.filter.common.FilterCreaturePermanent;
import mage.filter.predicate.mageobject.AnotherPredicate;
import mage.filter.StaticFilters;
/**
*
@ -19,11 +18,6 @@ import mage.filter.predicate.mageobject.AnotherPredicate;
*/
public final class VirulentEmissary extends CardImpl {
private static final FilterCreaturePermanent filter = new FilterCreaturePermanent("another creature");
static {
filter.add(AnotherPredicate.instance);
}
public VirulentEmissary(UUID ownerId, CardSetInfo setInfo) {
super(ownerId,setInfo,new CardType[]{CardType.CREATURE},"{G}");
this.subtype.add(SubType.ELF);
@ -36,7 +30,7 @@ public final class VirulentEmissary extends CardImpl {
this.addAbility(DeathtouchAbility.getInstance());
// Whenever another creature you control enters, you gain 1 life.
this.addAbility(new EntersBattlefieldControlledTriggeredAbility(new GainLifeEffect(1), filter));
this.addAbility(new EntersBattlefieldControlledTriggeredAbility(new GainLifeEffect(1), StaticFilters.FILTER_ANOTHER_CREATURE_YOU_CONTROL));
}
private VirulentEmissary(final VirulentEmissary card) {