Fix copying subabilities to no longer duplicate them (#11399)

* Fix Subability copy bug (fix #10526 )

* Cards which copy abilities of other cards should not copy subabilities.

* Enable previously-failing tests

* Find more addAbility that should be done without subabilities

* Add documentation to addAbility function

* Add warning about not using basic addAbility when copying from a source

* Invert withSubabilities to fromExistingObject
This commit is contained in:
ssk97 2023-11-12 16:57:39 -08:00 committed by GitHub
parent 3972e80860
commit ec4c79e0e0
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
39 changed files with 83 additions and 40 deletions

View file

@ -198,9 +198,7 @@ public class SquadTest extends CardTestPlayerBase {
}
// The squad status is a copiable value of the spell, and should be carried over on copy.
@Ignore
@Test
//TODO: Enable after fixing subability copying twice bug
public void test_CopyingSpellMustKeepSquadStatus() {
addCard(Zone.HAND, playerA, flagellant, 1);

View file

@ -80,7 +80,6 @@ public class CopyPermanentSpellTest extends CardTestPlayerBase {
assertPermanentCount(playerA, "Dead Weight", 2);
}
@Ignore // currently fails
@Test
public void testKickerTrigger() {
makeTester();
@ -98,7 +97,6 @@ public class CopyPermanentSpellTest extends CardTestPlayerBase {
assertPowerToughness(playerA, "Grizzly Bears", 4, 2);
}
@Ignore // currently fails
@Test
public void testKickerReplacement() {
makeTester();