refactor: improved usage of getSourceObjectZoneChangeCounter, added docs (part of #13737)

Mage.Sets/src/mage/cards/h/HaktosTheUnscarred.java

@@ -106,7 +106,7 @@ enum HaktosTheUnscarredPredicate implements ObjectSourcePlayerPredicate<Card> {
 
     @Override
     public boolean apply(ObjectSourcePlayer<Card> input, Game game) {
-        Object obj = game.getState().getValue(input.getSourceId() + "" + input.getSource().getSourceObjectZoneChangeCounter() + "_haktos_number");
+        Object obj = game.getState().getValue(input.getSourceId() + "" + input.getObject().getZoneChangeCounter(game) + "_haktos_number");
         if (!(obj instanceof Integer)) {
             return false;
         }

Mage.Sets/src/mage/cards/t/TalionTheKindlyLord.java

@@ -75,7 +75,7 @@ enum TalionTheKindlyLordPredicate implements ObjectSourcePlayerPredicate<StackOb
     public boolean apply(ObjectSourcePlayer<StackObject> input, Game game) {
         Object obj = game.getState().getValue(
                 "chosenNumber_" + input.getSource().getSourceId()
-                        + '_' + input.getSource().getSourceObjectZoneChangeCounter()
+                        + '_' + input.getObject().getZoneChangeCounter(game)
         );
         if (obj == null) {
             return false;

Mage/src/main/java/mage/abilities/Ability.java

@@ -516,6 +516,10 @@ public interface Ability extends Controllable, Serializable {
      */
     void initSourceObjectZoneChangeCounter(Game game, boolean force);
 
+    // TODO: it's activating time of ability, not current object's zcc, see #13737,
+    //   in most use cases you must use game.getState().getZoneChangeCounter or input.getObject().getZoneChangeCounter(game)
+    //   only ability related logic can use it (example: delayed triggers)
+    @Deprecated
     int getSourceObjectZoneChangeCounter();
 
     /**

Mage/src/main/java/mage/filter/predicate/mageobject/AnotherPredicate.java

@@ -16,8 +16,7 @@ public enum AnotherPredicate implements ObjectSourcePlayerPredicate<MageObject>
         if (!input.getObject().getId().equals(input.getSourceId())) {
             return true;
         }
-        int zcc = input.getSource().getSourceObjectZoneChangeCounter();
+        return false;
-        return zcc != 0 && zcc != input.getObject().getZoneChangeCounter(game);
     }
 
     @Override

Mage/src/main/java/mage/filter/predicate/permanent/SaddledSourceThisTurnPredicate.java

@@ -17,9 +17,9 @@ public enum SaddledSourceThisTurnPredicate implements ObjectSourcePlayerPredicat
 
     @Override
     public boolean apply(ObjectSourcePlayer<Permanent> input, Game game) {
-        return SaddledMountWatcher.checkIfSaddledThisTurn(
+        // for delayed triggers must use starting zcc (when delayed trigger created)
-                input.getObject(), new MageObjectReference(input.getSourceId(), input.getSource().getSourceObjectZoneChangeCounter(), game), game
+        MageObjectReference startingMor = new MageObjectReference(input.getSourceId(), input.getSource().getSourceObjectZoneChangeCounter(), game);
-        );
+        return SaddledMountWatcher.checkIfSaddledThisTurn(input.getObject(), startingMor, game);
     }
 
     @Override