Skip prompting player with no blockers to select blockers (#13496)

* Don't prompt creatureless player to select blockers

* Move getting possible blockers back to while loop

* Several preferences text improvements, always skip select blockers prompt if no blockers
This commit is contained in:
PurpleCrowbar 2025-04-03 18:34:04 +01:00 committed by GitHub
parent 35b0ae8abd
commit dfb6896453
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 9 additions and 8 deletions

View file

@ -2072,7 +2072,6 @@ public class HumanPlayer extends PlayerImpl {
// stop skip on any/zero permanents available
int possibleBlockersCount = game.getBattlefield().count(filter, playerId, source, game);
boolean canStopOnAny = possibleBlockersCount != 0 && getControllingPlayersUserData(game).getUserSkipPrioritySteps().isStopOnDeclareBlockersWithAnyPermanents();
boolean canStopOnZero = possibleBlockersCount == 0 && getControllingPlayersUserData(game).getUserSkipPrioritySteps().isStopOnDeclareBlockersWithZeroPermanents();
// skip declare blocker step
// as opposed to declare attacker - it can be skipped by ANY skip button TODO: make same for declare attackers and rework skip buttons (normal and forced)
@ -2081,9 +2080,11 @@ public class HumanPlayer extends PlayerImpl {
|| passedTurn
|| passedUntilEndOfTurn
|| passedUntilNextMain;
if (skipButtonActivated && !canStopOnAny && !canStopOnZero) {
if (skipButtonActivated && !canStopOnAny) {
return;
}
// Skip prompt to select blockers if player has none
if (possibleBlockersCount == 0) return;
while (canRespond()) {
prepareForResponse(game);