Remove most "has been deprecated" errors

Mage.Sets/src/mage/sets/avacynrestored/DarkImpostor.java

@@ -105,7 +105,7 @@ class DarkImpostorContinuousEffect extends ContinuousEffectImpl {
                 if (card != null) {
                     for (Ability ability: card.getAbilities()) {
                         if (ability instanceof ActivatedAbility) {
-                            perm.addAbility(ability, game);
+                            perm.addAbility(ability, source.getSourceId(), game);
                         }
                     }
                 }

Mage.Sets/src/mage/sets/avacynrestored/RidersOfGavony.java

@@ -110,7 +110,7 @@ class RidersOfGavonyEffect extends OneShotEffect {
             if (typeChoice.getChoice() != null) {
                 game.informPlayers(permanent.getName() + ": " + player.getLogName() + " has chosen " + typeChoice.getChoice());
                 game.getState().setValue(permanent.getId() + "_type", typeChoice.getChoice());
-                permanent.addInfo("chosen type", "<i>Chosen type: " + typeChoice.getChoice().toString() + "</i>", game);
+                permanent.addInfo("chosen type", "<i>Chosen type: " + typeChoice.getChoice() + "</i>", game);
             }
         }
         return false;
@@ -162,7 +162,7 @@ class RidersOfGavonyGainAbilityControlledEffect extends ContinuousEffectImpl {
         }
         if (protectionFilter != null) {
             for (Permanent perm: game.getBattlefield().getAllActivePermanents(filter, source.getControllerId(), game)) {
-                perm.addAbility(new ProtectionAbility(protectionFilter), game);
+                perm.addAbility(new ProtectionAbility(protectionFilter), source.getSourceId(), game);
             }
             return true;
         }

Mage.Sets/src/mage/sets/betrayersofkamigawa/SkullmaneBaku.java

@@ -110,7 +110,7 @@ public class SkullmaneBaku extends CardImpl {
             }
             Permanent creature = game.getPermanent(targetPointer.getFirst(game, source));
             if (creature != null && numberToUnboost != 0) {
-                creature.addAbility(new SimpleStaticAbility(Zone.BATTLEFIELD, new BoostSourceEffect(numberToUnboost, numberToUnboost, Duration.EndOfTurn)), game);
+                creature.addAbility(new SimpleStaticAbility(Zone.BATTLEFIELD, new BoostSourceEffect(numberToUnboost, numberToUnboost, Duration.EndOfTurn)), source.getSourceId(), game, false);
             }
             return true;
         }

Mage.Sets/src/mage/sets/commander2013/CurseOfChaos.java

@@ -140,7 +140,7 @@ class CurseOfChaosEffect extends OneShotEffect {
         Player attacker = game.getPlayer(this.getTargetPointer().getFirst(game, source));
         if (attacker != null) {
             if (attacker.getHand().size() > 0 && attacker.chooseUse(outcome, "Discard a card and draw a card?", game)){
-                attacker.discard(1, source, game);
+                attacker.discard(1, false, source, game);
                 attacker.drawCards(1, game);
             }
             return true;

Mage.Sets/src/mage/sets/dragonsmaze/BloodBaronOfVizkopa.java

@@ -126,7 +126,7 @@ class BloodBaronOfVizkopaEffect extends ContinuousEffectImpl {
                             break;
                         case AbilityAddingRemovingEffects_6:
                             if (sublayer == SubLayer.NA) {
-                                creature.addAbility(FlyingAbility.getInstance(), game);
+                                creature.addAbility(FlyingAbility.getInstance(), source.getSourceId(), game);
                             }
                             break;
                         default:

Mage.Sets/src/mage/sets/eventide/NeedleSpecter.java

@@ -98,7 +98,7 @@ class NeedleSpecterEffect extends OneShotEffect {
             Player targetPlayer = game.getPlayer(targetPointer.getFirst(game, source));
             if (targetPlayer != null) {
                 int damage = (Integer)getValue("damage");
-                targetPlayer.discard(damage, source, game);
+                targetPlayer.discard(damage, false, source, game);
                 game.informPlayers(targetPlayer.getLogName() + "discards " + damage + " card(s)");
                 return true;
             }

Mage.Sets/src/mage/sets/eventide/RiseOfTheHobgoblins.java

@@ -34,6 +34,7 @@ import mage.abilities.Ability;
 import mage.abilities.common.EntersBattlefieldTriggeredAbility;
 import mage.abilities.common.SimpleActivatedAbility;
 import mage.abilities.costs.mana.GenericManaCost;
+import mage.abilities.costs.mana.ManaCost;
 import mage.abilities.costs.mana.ManaCosts;
 import mage.abilities.costs.mana.ManaCostsImpl;
 import mage.abilities.effects.OneShotEffect;
@@ -116,7 +117,7 @@ class RiseOfTheHobgoblinsEffect extends OneShotEffect {
     @Override
     public boolean apply(Game game, Ability source) {
         Player you = game.getPlayer(source.getControllerId());
-        ManaCosts cost = new ManaCostsImpl("{X}");
+        ManaCosts<ManaCost> cost = new ManaCostsImpl<>("{X}");
         if (you != null && you.chooseUse(Outcome.Neutral, "Do you want to to pay {X}?", game)) {
             int costX = you.announceXMana(0, Integer.MAX_VALUE, "Announce the value for {X}", game, source);
             cost.add(new GenericManaCost(costX));

Mage.Sets/src/mage/sets/fifthedition/Recall.java

@@ -93,7 +93,7 @@ class RecallEffect extends OneShotEffect {
             // Discard X cards
             int amount = source.getManaCostsToPay().getX();
             int discarded = Math.min(amount, player.getHand().size());
-            player.discard(amount, source, game);
+            player.discard(amount, false, source, game);
             
             // then return a card from your graveyard to your hand for each card discarded this way
             TargetCardInYourGraveyard target = new TargetCardInYourGraveyard(discarded, new FilterCard());

Mage.Sets/src/mage/sets/innistrad/FrightfulDelusion.java

@@ -94,7 +94,7 @@ class FrightfulDelusionEffect extends OneShotEffect {
             if (player != null) {
                 cost.clearPaid();
                 game.getPlayer(spell.getControllerId()).discard(
-                        1, source, game);
+                        1, false, source, game);
                 if (!cost.pay(source, game, spell.getControllerId(),
                         spell.getControllerId(), false)) {
                     return game.getStack().counter(source.getFirstTarget(),

Mage.Sets/src/mage/sets/journeyintonyx/TormentedThoughts.java

@@ -105,7 +105,7 @@ class TormentedThoughtsDiscardEffect extends OneShotEffect {
                 }
             }
             if (power > 0) {
-                targetPlayer.discard(power, source, game);
+                targetPlayer.discard(power, false, source, game);
             }
             return true;
         }

Mage.Sets/src/mage/sets/legends/ChainsOfMephistopheles.java

@@ -103,7 +103,7 @@ class ChainsOfMephistophelesReplacementEffect extends ReplacementEffectImpl {
                 return true;
             } else  {
                 // discards a card instead. If the player discards a card this way, he or she draws a card.
-                player.discard(1, source, game);
+                player.discard(1, false, source, game);
                 return false; // because player draws a card, the draw event is kept
             }
         }

Mage.Sets/src/mage/sets/magic2011/DryadsFavor.java

@@ -29,13 +29,6 @@
 package mage.sets.magic2011;
 
 import java.util.UUID;
-import mage.constants.CardType;
-import mage.constants.Duration;
-import mage.constants.Layer;
-import mage.constants.Outcome;
-import mage.constants.Rarity;
-import mage.constants.SubLayer;
-import mage.constants.Zone;
 import mage.abilities.Ability;
 import mage.abilities.common.SimpleStaticAbility;
 import mage.abilities.effects.ContinuousEffectImpl;
@@ -43,6 +36,13 @@ import mage.abilities.effects.common.AttachEffect;
 import mage.abilities.keyword.EnchantAbility;
 import mage.abilities.keyword.ForestwalkAbility;
 import mage.cards.CardImpl;
+import mage.constants.CardType;
+import mage.constants.Duration;
+import mage.constants.Layer;
+import mage.constants.Outcome;
+import mage.constants.Rarity;
+import mage.constants.SubLayer;
+import mage.constants.Zone;
 import mage.game.Game;
 import mage.game.permanent.Permanent;
 import mage.target.TargetPermanent;
@@ -57,16 +57,16 @@ public class DryadsFavor extends CardImpl {
     public DryadsFavor(UUID ownerId) {
         super(ownerId, 169, "Dryad's Favor", Rarity.COMMON, new CardType[]{CardType.ENCHANTMENT}, "{G}");
         this.expansionSetCode = "M11";
-        this.color.setGreen(true);
         this.subtype.add("Aura");
 
+        // Enchant creature
         TargetPermanent auraTarget = new TargetCreaturePermanent();
         this.getSpellAbility().addTarget(auraTarget);
         this.getSpellAbility().addEffect(new AttachEffect(Outcome.Benefit));
         Ability ability = new EnchantAbility(auraTarget.getTargetName());
         this.addAbility(ability);
+        // Enchanted creature has forestwalk.
         this.addAbility(new SimpleStaticAbility(Zone.BATTLEFIELD, new DryadsFavorEffect()));
-
     }
 
     public DryadsFavor(final DryadsFavor card) {
@@ -104,7 +104,7 @@ class DryadsFavorEffect extends ContinuousEffectImpl {
                 switch (layer) {
                     case AbilityAddingRemovingEffects_6:
                         if (sublayer == SubLayer.NA) {
-                            creature.addAbility(new ForestwalkAbility(), game);
+                            creature.addAbility(new ForestwalkAbility(), source.getSourceId(), game);
                         }
                         break;
                 }

Mage.Sets/src/mage/sets/magic2011/VolcanicStrength.java

@@ -25,17 +25,9 @@
  *  authors and should not be interpreted as representing official policies, either expressed
  *  or implied, of BetaSteward_at_googlemail.com.
  */
-
 package mage.sets.magic2011;
 
 import java.util.UUID;
-import mage.constants.CardType;
-import mage.constants.Duration;
-import mage.constants.Layer;
-import mage.constants.Outcome;
-import mage.constants.Rarity;
-import mage.constants.SubLayer;
-import mage.constants.Zone;
 import mage.abilities.Ability;
 import mage.abilities.common.SimpleStaticAbility;
 import mage.abilities.effects.ContinuousEffectImpl;
@@ -43,6 +35,13 @@ import mage.abilities.effects.common.AttachEffect;
 import mage.abilities.keyword.EnchantAbility;
 import mage.abilities.keyword.MountainwalkAbility;
 import mage.cards.CardImpl;
+import mage.constants.CardType;
+import mage.constants.Duration;
+import mage.constants.Layer;
+import mage.constants.Outcome;
+import mage.constants.Rarity;
+import mage.constants.SubLayer;
+import mage.constants.Zone;
 import mage.game.Game;
 import mage.game.permanent.Permanent;
 import mage.target.TargetPermanent;
@@ -57,16 +56,16 @@ public class VolcanicStrength extends CardImpl {
     public VolcanicStrength(UUID ownerId) {
         super(ownerId, 158, "Volcanic Strength", Rarity.COMMON, new CardType[]{CardType.ENCHANTMENT}, "{1}{R}");
         this.expansionSetCode = "M11";
-        this.color.setRed(true);
         this.subtype.add("Aura");
 
+        // Enchant creature
         TargetPermanent auraTarget = new TargetCreaturePermanent();
         this.getSpellAbility().addTarget(auraTarget);
         this.getSpellAbility().addEffect(new AttachEffect(Outcome.BoostCreature));
         Ability ability = new EnchantAbility(auraTarget.getTargetName());
+        // Enchanted creature gets +2/+2 and has mountainwalk.
         this.addAbility(ability);
         this.addAbility(new SimpleStaticAbility(Zone.BATTLEFIELD, new VolcanicStrengthEffect()));
-
     }
 
     public VolcanicStrength(final VolcanicStrength card) {
@@ -127,7 +126,7 @@ class VolcanicStrengthEffect extends ContinuousEffectImpl {
 
     @Override
     public boolean hasLayer(Layer layer) {
-        return layer == Layer.AbilityAddingRemovingEffects_6 || layer == layer.PTChangingEffects_7;
+        return layer == Layer.AbilityAddingRemovingEffects_6 || layer == Layer.PTChangingEffects_7;
     }
 
 }

Mage.Sets/src/mage/sets/magic2013/VolcanicStrength.java

@@ -31,7 +31,7 @@ import java.util.UUID;
 
 /**
  *
- * @author North
+ * @author anonymous
  */
 public class VolcanicStrength extends mage.sets.magic2011.VolcanicStrength {
 

Mage.Sets/src/mage/sets/odyssey/LaquatussCreativity.java

@@ -87,7 +87,7 @@ class LaquatussCreativityEffect extends OneShotEffect {
         Player player = game.getPlayer(source.getFirstTarget());
         int handCount = player.getHand().count(new FilterCard(), game);
         player.drawCards(handCount, game);
-        player.discard(handCount, source, game);
+        player.discard(handCount, false, source, game);
         return false;
     }
 }

Mage.Sets/src/mage/sets/odyssey/TestamentOfFaith.java

@@ -137,7 +137,7 @@ class TestamentOfFaithBecomesCreatureSourceEffect extends ContinuousEffectImpl i
                     if (sublayer == SubLayer.NA) {
                         if (token.getAbilities().size() > 0) {
                             for (Ability ability: token.getAbilities()) {
-                                permanent.addAbility(ability, game);
+                                permanent.addAbility(ability, source.getSourceId(), game, false);
                             }
                         }
                     }

Mage.Sets/src/mage/sets/planechase2012/LastStand.java

@@ -135,7 +135,7 @@ class LastStandEffect extends OneShotEffect {
             int islands = game.getBattlefield().count(filterIsland, source.getSourceId(), source.getControllerId(), game);
             if (islands > 0) {
                 controller.drawCards(islands, game);
-                controller.discard(islands, source, game);
+                controller.discard(islands, false, source, game);
             }
 
         }

Mage.Sets/src/mage/sets/ravnica/CompulsiveResearch.java

@@ -94,7 +94,7 @@ class CompulsiveResearchDiscardEffect extends OneShotEffect {
             if (card != null) {
                 targetPlayer.discard(card, source, game);
                 if (!card.getCardType().contains(CardType.LAND) && !targetPlayer.getHand().isEmpty()) {
-                    targetPlayer.discard(1, source, game);
+                    targetPlayer.discard(1, false, source, game);
                 }
                 return true;
             }            

Mage.Sets/src/mage/sets/returntoravnica/AssassinsStrike.java

@@ -92,7 +92,7 @@ class AssassinsStrikeEffect extends OneShotEffect {
         if (permanent != null) {
             Player player = game.getPlayer(permanent.getControllerId());
             if (player != null) {
-                player.discard(1, source, game);
+                player.discard(1, false, source, game);
                 return true;
             }
         }

Mage.Sets/src/mage/sets/riseoftheeldrazi/InduceDespair.java

@@ -91,7 +91,7 @@ class InduceDespairEffect extends OneShotEffect {
         if (cost != null) {
             int CMC = -1 * cost.convertedManaCosts;
             if (creature != null) {
-                creature.addAbility(new SimpleStaticAbility(Zone.BATTLEFIELD, new BoostSourceEffect(CMC, CMC, Duration.EndOfTurn)), game);
+                creature.addAbility(new SimpleStaticAbility(Zone.BATTLEFIELD, new BoostSourceEffect(CMC, CMC, Duration.EndOfTurn)), source.getSourceId(), game, false);
             }
         }
         return true;

Mage.Sets/src/mage/sets/riseoftheeldrazi/ThoughtGorger.java

@@ -104,7 +104,7 @@ class ThoughtGorgerEffectEnters extends OneShotEffect {
         if (player != null && player.getHand().size() > 0 && thoughtGorger != null ) {
             int cardsInHand = player.getHand().size();
             thoughtGorger.addCounters(CounterType.P1P1.createInstance(cardsInHand), game);
-            player.discard(cardsInHand, source, game);
+            player.discard(cardsInHand, false, source, game);
             return true;
         }
         return false;

Mage.Sets/src/mage/sets/shadowmoor/Gloomlance.java

@@ -93,7 +93,7 @@ class GloomlanceEffect extends OneShotEffect {
             Permanent destroyedCreature = game.getPermanentOrLKIBattlefield(source.getFirstTarget());
             if (destroyedCreature.getColor().isGreen()
                     || destroyedCreature.getColor().isWhite()) {
-                targetController.discard(1, source, game);
+                targetController.discard(1, false, source, game);
                 return true;
             }
         }

Mage.Sets/src/mage/sets/urzaslegacy/MemoryJar.java

@@ -167,7 +167,7 @@ class MemoryJarDelayedEffect extends OneShotEffect {
                 Player player = game.getPlayer(playerId);
                 if (player != null)
                 {
-                    player.discard(player.getHand().size(), source, game);
+                    player.discard(player.getHand().size(), false, source, game);
                 }
             }
             //Return to hand

Mage.Sets/src/mage/sets/vintagemasters/DacksDuplicate.java

@@ -53,17 +53,15 @@ public class DacksDuplicate extends CardImpl {
         this.expansionSetCode = "VMA";
         this.subtype.add("Shapeshifter");
 
-        this.color.setRed(true);
-        this.color.setBlue(true);
         this.power = new MageInt(0);
         this.toughness = new MageInt(0);
 
         // You may have Dack's Duplicate enter the battlefield as a copy of any creature on the battlefield except it gains haste and dethrone.
         this.addAbility(new SimpleStaticAbility(
-            Zone.BATTLEFIELD,
+                Zone.BATTLEFIELD,
-            new EntersBattlefieldEffect(new CopyPermanentEffect(new DacksDuplicateApplyToPermanent()),
+                new EntersBattlefieldEffect(new CopyPermanentEffect(new DacksDuplicateApplyToPermanent()),
-            "You may have {this} enter the battlefield as a copy of any creature on the battlefield except it gains haste and dethrone",
+                        "You may have {this} enter the battlefield as a copy of any creature on the battlefield except it gains haste and dethrone",
-            true)));
+                        true)));
     }
 
     public DacksDuplicate(final DacksDuplicate card) {
@@ -77,8 +75,13 @@ public class DacksDuplicate extends CardImpl {
 }
 
 class DacksDuplicateApplyToPermanent extends ApplyToPermanent {
+
     @Override
     public Boolean apply(Game game, Permanent permanent) {
+        /**
+         * 29/05/2014	The ability of Dack’s Duplicate doesn’t target the
+         * creature.
+         */
         permanent.addAbility(new DethroneAbility(), game);
         permanent.addAbility(HasteAbility.getInstance(), game);
         return true;

Mage.Sets/src/mage/sets/visions/AnvilOfBogardan.java

@@ -90,7 +90,7 @@ class AnvilOfBogardanEffect extends OneShotEffect {
         Player targetPlayer = game.getPlayer(targetPointer.getFirst(game, source));
         if (targetPlayer != null) {
             targetPlayer.drawCards(1, game);
-            targetPlayer.discard(1, source, game);
+            targetPlayer.discard(1, false, source, game);
             return true;
         }
         return false;