External/mage
1
0
Fork 1
mirror of https://github.com/magefree/mage.git synced 2025-12-22 03:22:00 -08:00
Code Issues Projects Releases Packages Wiki Activity Actions

fixed unnecessary verify warnings for split cards

Browse source
This commit is contained in:
Evan Kranzler 2021-04-30 09:16:27 -04:00
parent bb46ac5ad6
commit c1f1ceb9e7
2 changed files with 10 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Mage.Sets/src/mage/cards/v/ValentinDeanOfTheVein.java
View file

@ -33,7 +33,7 @@ public final class ValentinDeanOfTheVein extends ModalDoubleFacesCard {
public ValentinDeanOfTheVein(UUID ownerId, CardSetInfo setInfo) { public ValentinDeanOfTheVein(UUID ownerId, CardSetInfo setInfo) {
super(ownerId, setInfo, super(ownerId, setInfo,
new CardType[]{CardType.CREATURE}, new SubType[]{SubType.VAMPIRE, SubType.WARLOCK}, "{B}", new CardType[]{CardType.CREATURE}, new SubType[]{SubType.VAMPIRE, SubType.WARLOCK}, "{B}",
"Lisette Dean of the Root", new CardType[]{CardType.CREATURE}, new SubType[]{SubType.HUMAN, SubType.DRUID}, "{2}{G}{G}" "Lisette, Dean of the Root", new CardType[]{CardType.CREATURE}, new SubType[]{SubType.HUMAN, SubType.DRUID}, "{2}{G}{G}"
); );
// 1. // 1.

18
Mage.Verify/src/test/java/mage/verify/VerifyCardDataTest.java
View file

@ -267,13 +267,13 @@ public class VerifyCardDataTest {
for (Card card : CardScanner.getAllCards()) { for (Card card : CardScanner.getAllCards()) {
cardIndex++; cardIndex++;
if (card instanceof SplitCard) { if (card instanceof SplitCard) {
check(((SplitCard) card).getLeftHalfCard(), cardIndex); check(((SplitCard) card).getLeftHalfCard(), cardIndex, true);
check(((SplitCard) card).getRightHalfCard(), cardIndex); check(((SplitCard) card).getRightHalfCard(), cardIndex, true);
} else if (card instanceof ModalDoubleFacesCard) { } else if (card instanceof ModalDoubleFacesCard) {
check(((ModalDoubleFacesCard) card).getLeftHalfCard(), cardIndex); check(((ModalDoubleFacesCard) card).getLeftHalfCard(), cardIndex, false);
check(((ModalDoubleFacesCard) card).getRightHalfCard(), cardIndex); check(((ModalDoubleFacesCard) card).getRightHalfCard(), cardIndex, false);
} else { } else {
check(card, cardIndex); check(card, cardIndex, false);
} }
} }
@ -1171,13 +1171,13 @@ public class VerifyCardDataTest {
} }
} }
private void check(Card card, int cardIndex) { private void check(Card card, int cardIndex, boolean skipWarning) {
MtgJsonCard ref = MtgJsonService.cardFromSet(card.getExpansionSetCode(), card.getName(), card.getCardNumber()); MtgJsonCard ref = MtgJsonService.cardFromSet(card.getExpansionSetCode(), card.getName(), card.getCardNumber());
if (ref == null) { if (ref != null) {
checkAll(card, ref, cardIndex);
} else if (!skipWarning) {
warn(card, "Missing card reference"); warn(card, "Missing card reference");
return;
} }
checkAll(card, ref, cardIndex);
} }
private boolean contains(Collection<String> options, String value) { private boolean contains(Collection<String> options, String value) {