External/mage
1
0
Fork 1
mirror of https://github.com/magefree/mage.git synced 2025-12-20 02:30:08 -08:00
Code Issues Projects Releases Packages Wiki Activity Actions

tests: improved bad conditions test (related to #13752)

Browse source
This commit is contained in:
Oleg Agafonov 2025-06-14 18:09:19 +04:00
parent fe18aa9f4a
commit bcac563272
1 changed files with 23 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

30
Mage.Verify/src/test/java/mage/verify/VerifyCardDataTest.java
View file

@ -1698,11 +1698,12 @@ public class VerifyCardDataTest {
} }
@Test @Test
@Ignore // experimental test to find potentially fail conditions with NPE see https://github.com/magefree/mage/issues/13752 @Ignore
// experimental test to find potentially fail conditions with NPE see https://github.com/magefree/mage/issues/13752
public void test_checkBadConditions() { public void test_checkBadConditions() {
// all conditions in AsThoughEffect must be compatible with empty source param (e.g. must be able to use inside ConditionalAsThoughEffect) // all conditions in AsThoughEffect must be compatible with empty source param (e.g. must be able to use inside ConditionalAsThoughEffect)
// see AsThoughEffectType.needAffectedAbility ? // see AsThoughEffectType.needAffectedAbility ?
// 450+ failed conditions // 370+ failed conditions
Collection<String> errorsList = new ArrayList<>(); Collection<String> errorsList = new ArrayList<>();
Game fakeGame = new FakeGame(); Game fakeGame = new FakeGame();
Ability fakeAbility = new SimpleStaticAbility(new InfoEffect("fake")); Ability fakeAbility = new SimpleStaticAbility(new InfoEffect("fake"));
@ -1716,15 +1717,30 @@ public class VerifyCardDataTest {
.collect(Collectors.toCollection(LinkedHashSet::new)); .collect(Collectors.toCollection(LinkedHashSet::new));
for (Class<?> enumClass : conditionEnums) { for (Class<?> enumClass : conditionEnums) {
for (Object enumItem : enumClass.getEnumConstants()) { for (Object enumItem : enumClass.getEnumConstants()) {
// miss watcher will fail in both use cases, but miss ability only one
String errorOnAbility = "";
try { try {
((Condition) enumItem).apply(fakeGame, fakeAbility); ((Condition) enumItem).apply(fakeGame, fakeAbility);
} catch (Exception e) {
errorOnAbility = Arrays.stream(e.getStackTrace())
.map(StackTraceElement::toString)
.limit(5)
.collect(Collectors.joining("\n"));
}
String errorOnEmptyAbility = "";
try {
((Condition) enumItem).apply(fakeGame, null); ((Condition) enumItem).apply(fakeGame, null);
} catch (Exception e) { } catch (Exception e) {
if (e.toString().contains("watchers")) { errorOnEmptyAbility = Arrays.stream(e.getStackTrace())
// ignore miss watcher errors cause it's fake game .map(StackTraceElement::toString)
continue; .limit(5)
} .collect(Collectors.joining("\n"));
e.printStackTrace(); }
if (errorOnAbility.isEmpty() && !errorOnEmptyAbility.isEmpty()) {
System.out.println();
System.out.println("bad condition " + enumClass.getName() + "\n" + errorOnEmptyAbility);
errorsList.add("Error: condition must support empty and non-empty source params: " + enumClass.getName()); errorsList.add("Error: condition must support empty and non-empty source params: " + enumClass.getName());
} }
} }