From b746a601f21955a4c1864e63532b70ca028c7b9f Mon Sep 17 00:00:00 2001 From: Oleg Agafonov Date: Tue, 12 Mar 2024 11:13:43 +0400 Subject: [PATCH] docs: added additional comments for #11933 --- Mage/src/main/java/mage/target/Target.java | 4 ++++ Mage/src/main/java/mage/target/TargetImpl.java | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/Mage/src/main/java/mage/target/Target.java b/Mage/src/main/java/mage/target/Target.java index 882a0314d40..8e674c693b9 100644 --- a/Mage/src/main/java/mage/target/Target.java +++ b/Mage/src/main/java/mage/target/Target.java @@ -139,6 +139,10 @@ public interface Target extends Serializable { boolean isRandom(); + /** + * WARNING, if you need random choice then call it by target's choose method, not player's choose + * see https://github.com/magefree/mage/issues/11933 + */ void setRandom(boolean atRandom); UUID getFirstTarget(); diff --git a/Mage/src/main/java/mage/target/TargetImpl.java b/Mage/src/main/java/mage/target/TargetImpl.java index f6adbeb4e0b..a03cc1052cd 100644 --- a/Mage/src/main/java/mage/target/TargetImpl.java +++ b/Mage/src/main/java/mage/target/TargetImpl.java @@ -34,7 +34,7 @@ public abstract class TargetImpl implements Target { protected boolean chosen = false; // is the target handled as targeted spell/ability (notTarget = true is used for not targeted effects like e.g. sacrifice) protected boolean notTarget = false; - protected boolean atRandom = false; + protected boolean atRandom = false; // for inner choose logic protected UUID targetController = null; // if null the ability controller is the targetController protected UUID abilityController = null; // only used if target controller != ability controller