External/mage
1
0
Fork 1
mirror of https://github.com/magefree/mage.git synced 2025-12-20 02:30:08 -08:00
Code Issues Projects Releases Packages Wiki Activity Actions

GUI: fixed that pick choice dialog can freeze on search text deleting (closes #8671);

Browse source
This commit is contained in:
Oleg Agafonov 2024-07-19 11:55:16 +04:00
parent e5912b227a
commit b07e7b3733
1 changed files with 6 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

10
Mage.Client/src/main/java/mage/client/dialog/PickChoiceDialog.java
View file

@ -39,7 +39,6 @@ public class PickChoiceDialog extends MageDialog {
UUID gameId;
java.util.List<KeyValueItem> allItems = new ArrayList<>();
DefaultListModel<KeyValueItem> dataModel = new DefaultListModel<>();
final private static String HTML_HEADERS_TEMPLATE = "<html><div style='text-align: center;'>%s</div></html>";
@ -58,7 +57,7 @@ public class PickChoiceDialog extends MageDialog {
int newHeight = GUISizeHelper.guiSizeScale(this.getSize().height, guiScale);
this.setSize(newWidth, newHeight);
this.listChoices.setModel(dataModel);
this.listChoices.setModel(new DefaultListModel<KeyValueItem>());
this.setModal(true);
}
@ -372,12 +371,15 @@ public class PickChoiceDialog extends MageDialog {
}
filter = filter.toLowerCase(Locale.ENGLISH);
this.dataModel.clear();
// make changes to new model instead current, so it can help with GUI freeze on fast text deleting
// https://github.com/magefree/mage/issues/8671
DefaultListModel<KeyValueItem> newModel = new DefaultListModel<>();
for (KeyValueItem item : this.allItems) {
if (!choice.isSearchEnabled() || item.getValue().toLowerCase(Locale.ENGLISH).contains(filter)) {
this.dataModel.addElement(item);
newModel.addElement(item);
}
}
this.listChoices.setModel(newModel);
}
private void setMessageText(MageEditorPane editor, String text) {